[Server] Do not perform encode/decode of token when making requests to Provider #11057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: MUzairS15 <muzair.shaikh810@gmail.com>
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #11057 +/- ##
=======================================
Coverage 9.00% 9.00%
=======================================
Files 146 146
Lines 19274 19274
=======================================
Hits 1736 1736
Misses 17236 17236
Partials 302 302
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes for Reviewers
When making requests to the remote provider, the JWT issued was being decoded on the server side. The PR ensures that decoding now occurs directly at the provider, making the Meshery server independent of this process. This adjustment also ensures adaptability in case of any alterations in the Remote Provider's encoding/decoding or token verification procedures.
Signed commits