Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mesheryctl] Support quoted args and refactoring code in mesheryctl perf #4823

Merged
merged 5 commits into from Jan 17, 2022

Conversation

piyushsingariya
Copy link
Contributor

Signed-off-by: Piyush Singariya piyushsingariya@gmail.com

Description

  • Now added support for quoted args in mesheryctl perf subcommands
  • Interactive flush screen for multi-profile confirmation in mesheryctl apply
  • Refactored code to reuse code across the package

This PR fixes #

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Piyush Singariya <piyushsingariya@gmail.com>
Signed-off-by: Piyush Singariya <piyushsingariya@gmail.com>
Signed-off-by: Piyush Singariya <piyushsingariya@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Dec 23, 2021

Codecov Report

Merging #4823 (41d0d29) into master (66e6352) will increase coverage by 0.05%.
The diff coverage is 72.46%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4823      +/-   ##
==========================================
+ Coverage   32.39%   32.45%   +0.05%     
==========================================
  Files          61       61              
  Lines        5065     5025      -40     
==========================================
- Hits         1641     1631      -10     
+ Misses       3014     2990      -24     
+ Partials      410      404       -6     
Flag Coverage Δ
gointegrationtests 9.33% <5.79%> (+0.11%) ⬆️
unittests 25.87% <72.46%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mesheryctl/internal/cli/root/perf/apply.go 42.04% <68.42%> (+3.81%) ⬆️
mesheryctl/internal/cli/root/perf/profile.go 45.71% <73.07%> (-4.29%) ⬇️
mesheryctl/internal/cli/root/perf/result.go 68.90% <75.00%> (+1.95%) ⬆️
mesheryctl/internal/cli/root/system/start.go 56.58% <0.00%> (+0.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66e6352...41d0d29. Read the comment docs.

Signed-off-by: Piyush Singariya <piyushsingariya@gmail.com>
@leecalcote
Copy link
Member

Does this command still support search terms that are not enclosed in quotation marks?

@piyushsingariya
Copy link
Contributor Author

Does this command still support search terms that are not enclosed in quotation marks?

Yes ofcourse.

@leecalcote
Copy link
Member

@navendu-pottekkat @hexxdump what feedback do you have here?

@leecalcote leecalcote requested review from hexxdump and removed request for Revolyssup December 31, 2021 21:22
@leecalcote
Copy link
Member

@navendu-pottekkat @hexxdump what feedback do you have here?

leecalcote
leecalcote previously approved these changes Jan 15, 2022
@leecalcote
Copy link
Member

@piyushsingariya a merge conflict has come up...

@leecalcote leecalcote added the area/performance Features/bugs having to do with Performance Management label Jan 15, 2022
…ctions

Signed-off-by: Piyush Singariya <piyushsingariya@gmail.com>
@piyushsingariya
Copy link
Contributor Author

Conflict resolved and Tested ready to merge

@leecalcote leecalcote merged commit cd18f99 into meshery:master Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/performance Features/bugs having to do with Performance Management component/mesheryctl CLI for Meshery
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants