Skip to content

Conversation

@poliver
Copy link
Member

@poliver poliver commented Oct 8, 2025

What does this PR do?

Changes the package name of generated java/kotlin files from com.geeksville.mesh to org.meshtastic.proto

Relevant draft PR in the Android repo: meshtastic/Meshtastic-Android#3291

Checklist before merging

  • All top level messages commented
  • All enum members have unique descriptions

New Hardware Model Acceptance Policy

Due to limited availability and ongoing support, new Hardware Models will only be accepted from Meshtastic Backers and Partners. The Meshtastic team reserves the right to make exceptions to this policy.

Alternative for Community Contributors

You are welcome to use one of the existing DIY hardware models in your PlatformIO environment and create a pull request in the firmware project. Please note the following conditions:

  • The device will not be officially supported by the core Meshtastic team.
  • The device will not appear in the Web Flasher or Github release assets.
  • You will be responsible for ongoing maintenance and support.
  • Community-contributed / DIY hardware models are considered experimental and will likely have limited or no testing.

Getting Official Support

To have your hardware model officially supported and included in the Meshtastic ecosystem, consider becoming a Meshtastic Backer or Partner. Visit meshtastic.com for more information about partnership opportunities.

@thebentern thebentern merged commit fecb769 into master Oct 8, 2025
1 of 2 checks passed
@thebentern thebentern deleted the java_package branch October 8, 2025 16:56
@github-actions
Copy link

github-actions bot commented Oct 8, 2025

The latest Buf updates on your PR. Results from workflow pull-request / build (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed❌ failed (23)Oct 8, 2025, 4:57 PM

@fifieldt
Copy link
Member

fifieldt commented Oct 8, 2025

This has broken the CI tests in this repo:

/opt/hostedtoolcache/buf/1.57.2/x64/buf breaking --error-format github-actions --against https://github.com/meshtastic/protobufs.git#format=git,commit=1ecf94da9898ea0b8f2745bfe6bda2a8f2ca4073
Error: File option "java_package" changed from "com.geeksville.mesh" to "org.meshtastic.proto".
Error: File option "java_package" changed from "com.geeksville.mesh" to "org.meshtastic.proto".
Error: File option "java_package" changed from "com.geeksville.mesh" to "org.meshtastic.proto".
Error: File option "java_package" changed from "com.geeksville.mesh" to "org.meshtastic.proto".
Error: File option "java_package" changed from "com.geeksville.mesh" to "org.meshtastic.proto".
Error: File option "java_package" changed from "com.geeksville.mesh" to "org.meshtastic.proto".
Error: File option "java_package" changed from "com.geeksville.mesh" to "org.meshtastic.proto".

@jamesarich
Copy link
Contributor

This has broken the CI tests in this repo:

it looks like buf crapped out - what do we need to do to fix it up @fifieldt

@fifieldt
Copy link
Member

fifieldt commented Oct 8, 2025

I wish I knew :(

jamesarich added a commit that referenced this pull request Oct 8, 2025
Explicitly ignore that we changed the `java_package` - we know, bro, it was on purpose.

This is to handle the `buf` build errors introduced in #788.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants