Skip to content

Conversation

@ianmcorvidae
Copy link
Contributor

Pretty simple, so adding an argument for it. Accepts either nodeId in decimal or as hex with a prefix of '!'.

@rcarteraz
Copy link
Member

Pretty simple, so adding an argument for it. Accepts either nodeId in decimal or as hex with a prefix of '!'.

Nice! Especially being able to do both decimal or hex.

@codecov
Copy link

codecov bot commented Apr 8, 2024

Codecov Report

Attention: Patch coverage is 23.52941% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 63.77%. Comparing base (9f2b54e) to head (439b1ad).

Files Patch % Lines
meshtastic/node.py 16.66% 10 Missing ⚠️
meshtastic/__main__.py 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #541      +/-   ##
==========================================
- Coverage   64.01%   63.77%   -0.25%     
==========================================
  Files          14       14              
  Lines        2840     2857      +17     
==========================================
+ Hits         1818     1822       +4     
- Misses       1022     1035      +13     
Flag Coverage Δ
unittests 63.77% <23.52%> (-0.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ianmcorvidae ianmcorvidae merged commit b280d0b into meshtastic:master Apr 8, 2024
@ianmcorvidae ianmcorvidae deleted the removenode branch April 18, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants