Enhance get_channels_with_hash() #859
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To set the index 0 name to the preset name from localConfig.lora.modem_prese and compute hash so the output will not have bad index0 name or hash, also removes all disabled for clarity. this outputs `Device1 Channel Hash Table: [{'index': 0, 'role': 'PRIMARY', 'name': 'LongFast', 'hash': 8}` for a LongFast
ianmcorvidae
requested changes
Nov 12, 2025
Contributor
ianmcorvidae
left a comment
ianmcorvidae
left a comment
There was a problem hiding this comment.
A couple of issues here -- the generated names won't always be right as-is and this needs to be done for secondary channels too. But a good change in general/otherwise
Co-authored-by: Ian McEwen <ian@ianmcorvidae.net>
modem preset is set to none, the name used should be Custom
SpudGunMan
added a commit
to SpudGunMan/python
that referenced
this pull request
Nov 23, 2025
refactoring per comments in meshtastic#859
Contributor
Author
refactored to handle issues I hope? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To set the index 0 name to the preset name from localConfig.lora.modem_preset when empty
and compute hash so the output will not have bad index0 name or hash, also removes all disabled for clarity.
This outputs
Device1 Channel Hash Table: [{'index': 0, 'role': 'PRIMARY', 'name': 'LongFast', 'hash': 8}for a LongFast