Skip to content

Minor style fixes #596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 3, 2025
Merged

Minor style fixes #596

merged 1 commit into from
May 3, 2025

Conversation

@philon-
Copy link
Contributor

@philon- philon- commented May 2, 2025

Description

Minor style changes

Changes Made

  • Collapse button now has bg-background-primary so that it is not transparent (looked bad in map view)
  • Check boxes now inherit the check color from the parent object's text color, so that the map filter boxes render well on light background (despite dark mode)
  • Some auto formatting by deno...

Screenshots

Old:
Screenshot From 2025-05-03 00-05-05

New:
Screenshot From 2025-05-03 00-05-42

Checklist

  • Code follows project style guidelines
  • Dependent changes have been merged

@vercel
Copy link

vercel bot commented May 2, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-test ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 2, 2025 10:40pm

danditomaso
danditomaso reviewed May 3, 2025
View reviewed changes
Copy link
Collaborator

@danditomaso danditomaso left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good, but can I ask if you have the Deno extension installed for VSCode?

@danditomaso danditomaso merged commit cfcc9f8 into meshtastic:master May 3, 2025
4 checks passed
@philon- philon- deleted the style-fixes branch May 3, 2025 18:49
This was referenced May 14, 2025
Open
Closed
Closed
@renovate renovate bot mentioned this pull request Jun 3, 2025
Merged
1 task
@renovate renovate bot mentioned this pull request Jun 10, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danditomaso danditomaso danditomaso left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@philon- @danditomaso