Skip to content

Conversation

@philon-
Copy link
Contributor

@philon- philon- commented Aug 9, 2025

Description

This PR fixes some test cases for checkboxes as well as addresses an issue with spacing for the filter control options.

Related Issues

Changes Made

  • Added controlled / uncontrolled logic to checkboxes
  • Updated tests to reflect controlled/uncontrolled
  • Updated Checkbox ClassName in FilterComponents

Testing Done

Screenshots (if applicable)

Checklist

  • Code follows project style guidelines
  • Documentation has been updated or added
  • Tests have been added or updated
  • All i18n translation labels have been added (read
    CONTRIBUTING_I18N_DEVELOPER_GUIDE.md for more details)

Copilot AI review requested due to automatic review settings August 9, 2025 11:17
@vercel
Copy link

vercel bot commented Aug 9, 2025

@philon- is attempting to deploy a commit to the Meshtastic Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes checkbox test cases and improves the Checkbox component's controlled/uncontrolled state handling. It also addresses spacing issues in the filter control options.

  • Added controlled and uncontrolled logic to the Checkbox component with proper state management
  • Updated all checkbox tests to cover both controlled and uncontrolled scenarios
  • Fixed spacing for filter component options by adding appropriate CSS classes

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
packages/web/src/components/UI/Checkbox/index.tsx Implements controlled/uncontrolled checkbox logic with internal state management
packages/web/src/components/UI/Checkbox/Checkbox.test.tsx Comprehensive test updates covering controlled and uncontrolled checkbox behavior
packages/web/src/components/generic/Filter/FilterComponents.tsx Adds spacing classes to improve filter option layout

@danditomaso danditomaso merged commit a7f56c0 into meshtastic:main Aug 10, 2025
2 of 3 checks passed
@philon- philon- deleted the fix-checkbox-component branch August 10, 2025 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants