Skip to content

Conversation

@philon-
Copy link
Contributor

@philon- philon- commented Aug 9, 2025

Description

This PR makes minor changes to the NodeDetailsDialog UI.

Related Issues

Fixes #765

Changes Made

  • Refactored NodeDetailsDialog to use tables for better layout and readability
  • Added a security section displaying public key and verification status
  • Included messageable status.
  • Updated i18n files with new keys
  • Improved battery level formatting.
  • Fixed logic in Nodes page for handling location packets to stop location dialog from opening at connect
  • Improved hardware model sorting (linting error)

Testing Done

Screenshots (if applicable)

Screenshot 2025-08-09 at 23 16 38

Checklist

  • Code follows project style guidelines
  • Documentation has been updated or added
  • Tests have been added or updated
  • All i18n translation labels have been added (read
    CONTRIBUTING_I18N_DEVELOPER_GUIDE.md for more details)

philon- added 2 commits August 9, 2025 23:18
Refactored NodeDetailsDialog to use tables for better layout and readability, added a security section displaying public key and verification status, and included messageable status. Updated i18n files with new keys and improved battery level formatting. Fixed logic in Nodes page for handling location packets and improved hardware model sorting.
Copilot AI review requested due to automatic review settings August 9, 2025 21:24
@vercel
Copy link

vercel bot commented Aug 9, 2025

@philon- is attempting to deploy a commit to the Meshtastic Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves the NodeDetailsDialog UI by refactoring the layout to use tables for better organization and adding a new security section. The changes enhance readability and provide users with additional node information including public key data and verification status.

  • Refactored node details display to use table layouts instead of paragraph elements
  • Added a security section showing public key information and manual verification status
  • Fixed location packet handling logic to prevent unwanted dialog opening on connect

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File Description
packages/web/src/pages/Nodes/index.tsx Fixed location packet handling logic and hardware model sorting
packages/web/src/components/Dialog/NodeDetailsDialog/NodeDetailsDialog.tsx Refactored UI layout to use tables and added security section with public key display
packages/web/public/i18n/locales/en/dialog.json Added new translation keys for security section and corrected node hex prefix
packages/web/public/i18n/locales/en/common.json Added "yes" and "no" translation keys

@danditomaso
Copy link
Collaborator

danditomaso commented Aug 10, 2025

One question about this PR, in the newly designed dialog (which looks great btw). Why is the public key font smaller than the note text below it?

@philon-
Copy link
Contributor Author

philon- commented Aug 10, 2025

One question about this PR, in the newly designed dialog (which looks great btw). Why is the public key font smaller than the note text below it?

The idea was to fit on the same line in the dialog, but this can be changed. I agree it's not great looking but the alternatives I tried were worse in my opinion. I can have another look at it.

Future ideas were to add buttons for key verification in that same section, but there's more work required for that.

@danditomaso danditomaso merged commit 176d554 into meshtastic:main Aug 11, 2025
2 of 3 checks passed
@philon- philon- deleted the fix-765 branch August 11, 2025 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request]: Show hex public key on node details screen

2 participants