-
Notifications
You must be signed in to change notification settings - Fork 221
Improve NodeDetailsDialog UI and add security info #770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Refactored NodeDetailsDialog to use tables for better layout and readability, added a security section displaying public key and verification status, and included messageable status. Updated i18n files with new keys and improved battery level formatting. Fixed logic in Nodes page for handling location packets and improved hardware model sorting.
|
@philon- is attempting to deploy a commit to the Meshtastic Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR improves the NodeDetailsDialog UI by refactoring the layout to use tables for better organization and adding a new security section. The changes enhance readability and provide users with additional node information including public key data and verification status.
- Refactored node details display to use table layouts instead of paragraph elements
- Added a security section showing public key information and manual verification status
- Fixed location packet handling logic to prevent unwanted dialog opening on connect
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| packages/web/src/pages/Nodes/index.tsx | Fixed location packet handling logic and hardware model sorting |
| packages/web/src/components/Dialog/NodeDetailsDialog/NodeDetailsDialog.tsx | Refactored UI layout to use tables and added security section with public key display |
| packages/web/public/i18n/locales/en/dialog.json | Added new translation keys for security section and corrected node hex prefix |
| packages/web/public/i18n/locales/en/common.json | Added "yes" and "no" translation keys |
packages/web/src/components/Dialog/NodeDetailsDialog/NodeDetailsDialog.tsx
Show resolved
Hide resolved
packages/web/src/components/Dialog/NodeDetailsDialog/NodeDetailsDialog.tsx
Show resolved
Hide resolved
packages/web/src/components/Dialog/NodeDetailsDialog/NodeDetailsDialog.tsx
Show resolved
Hide resolved
packages/web/src/components/Dialog/NodeDetailsDialog/NodeDetailsDialog.tsx
Show resolved
Hide resolved
|
One question about this PR, in the newly designed dialog (which looks great btw). Why is the public key font smaller than the note text below it? |
The idea was to fit on the same line in the dialog, but this can be changed. I agree it's not great looking but the alternatives I tried were worse in my opinion. I can have another look at it. Future ideas were to add buttons for key verification in that same section, but there's more work required for that. |
Description
This PR makes minor changes to the NodeDetailsDialog UI.
Related Issues
Fixes #765
Changes Made
Testing Done
Screenshots (if applicable)
Checklist
CONTRIBUTING_I18N_DEVELOPER_GUIDE.md for more details)