Skip to content

Conversation

@philon-
Copy link
Contributor

@philon- philon- commented Aug 10, 2025

Description

This is a PR which attempts to address some issues with CI workflows

Related Issues

Changes Made

  • Don't attempt publishing web for release-packages workflow
  • Add explicit meshtastic/core deps for transport packages
  • Change to workspace:* dependencies in monorepo packages
  • Change dist folder pointer in Dockerfile
  • Update pnpm-lock

Testing Done

Tested locally using ACT, some testing in my own fork.

Screenshots (if applicable)

Checklist

  • Code follows project style guidelines
  • Documentation has been updated or added
  • Tests have been added or updated
  • All i18n translation labels have been added (read
    CONTRIBUTING_I18N_DEVELOPER_GUIDE.md for more details)

Copilot AI review requested due to automatic review settings August 10, 2025 14:02
@vercel
Copy link

vercel bot commented Aug 10, 2025

@philon- is attempting to deploy a commit to the Meshtastic Team on Vercel.

A member of the Team first needs to authorize it.

This comment was marked as outdated.

@philon- philon- force-pushed the attempt-fix-docker-build branch from 192e95e to c530a54 Compare August 10, 2025 15:13
@philon- philon- force-pushed the attempt-fix-docker-build branch from c530a54 to d03fcf5 Compare August 10, 2025 15:15
@philon- philon- requested a review from Copilot August 10, 2025 15:16
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes Docker and CI build issues by updating the project to use a monorepo setup with proper workspace dependencies and updated build configurations.

  • Standardizes package build configurations across all transport packages
  • Updates dependency references to use workspace:* pattern for internal packages
  • Adds proper vitest configuration for monorepo testing setup

Reviewed Changes

Copilot reviewed 15 out of 16 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
vitest.config.ts Root vitest config for monorepo test projects
packages/web/vitest.config.ts Updated web package test config with corrected paths
packages/web/package.json Changed transport dependencies to workspace references
packages/web/infra/Containerfile Fixed Docker dist folder path
packages/transport-*/package.json Added @meshtastic/core dependencies and standardized tsdown config
package.json Added vitest dependency and test script
.github/workflows/*.yml Updated CI workflows to use pnpm and skip web package in releases
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

@danditomaso
Copy link
Collaborator

There was also an issue around the build.tar not being created when a release or pre-release is created, does this PR address this?

@philon-
Copy link
Contributor Author

philon- commented Aug 10, 2025

There was also an issue around the build.tar not being created when a release or pre-release is created, does this PR address this?

Yes... should. 😉

Copy link
Collaborator

@danditomaso danditomaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good!

@danditomaso danditomaso merged commit 2735c37 into meshtastic:main Aug 11, 2025
1 of 2 checks passed
@philon- philon- deleted the attempt-fix-docker-build branch August 12, 2025 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants