-
Notifications
You must be signed in to change notification settings - Fork 221
Fix Docker and CI builds #773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Docker and CI builds #773
Conversation
|
@philon- is attempting to deploy a commit to the Meshtastic Team on Vercel. A member of the Team first needs to authorize it. |
192e95e to
c530a54
Compare
c530a54 to
d03fcf5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes Docker and CI build issues by updating the project to use a monorepo setup with proper workspace dependencies and updated build configurations.
- Standardizes package build configurations across all transport packages
- Updates dependency references to use workspace:* pattern for internal packages
- Adds proper vitest configuration for monorepo testing setup
Reviewed Changes
Copilot reviewed 15 out of 16 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| vitest.config.ts | Root vitest config for monorepo test projects |
| packages/web/vitest.config.ts | Updated web package test config with corrected paths |
| packages/web/package.json | Changed transport dependencies to workspace references |
| packages/web/infra/Containerfile | Fixed Docker dist folder path |
| packages/transport-*/package.json | Added @meshtastic/core dependencies and standardized tsdown config |
| package.json | Added vitest dependency and test script |
| .github/workflows/*.yml | Updated CI workflows to use pnpm and skip web package in releases |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
|
There was also an issue around the build.tar not being created when a release or pre-release is created, does this PR address this? |
Yes... should. 😉 |
danditomaso
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good!
Description
This is a PR which attempts to address some issues with CI workflows
Related Issues
Changes Made
Testing Done
Tested locally using ACT, some testing in my own fork.
Screenshots (if applicable)
Checklist
CONTRIBUTING_I18N_DEVELOPER_GUIDE.md for more details)