Refactor svg #47

Open
wants to merge 4 commits into
from

Projects

None yet

2 participants

@meshy
Owner
meshy commented May 18, 2014

No description provided.

@meshy
Owner
meshy commented Nov 1, 2014

@Ian-Foote would you be interested in giving this a look over?

@meshy
Owner
meshy commented Nov 1, 2014

FWIW, I'd be happy for you to reject this change if you don't see it as an improvement. My motivation for this refactor was primarily a better understanding of the code. Loving tau, btw :)

@Ian-Foote Ian-Foote and 1 other commented on an outdated diff Nov 2, 2014
}
return PATH_TEMPLATE.format(**points)
-def add_annular_sector(wheel, start, stop, style_class):
- return et.SubElement(
- wheel, 'path',
- d=annular_sector_path(start=start, stop=stop),
- attrib={'class': style_class},
- )
+def add_annular_sectors(wheel, packages, total):
+ for index, result in enumerate(packages):
+ sector = et.SubElement(
+ wheel, 'path',
@Ian-Foote
Ian-Foote Nov 2, 2014 Collaborator
    wheel,
    'path',
@meshy
meshy Nov 2, 2014 Owner

👍 This could probably do with kwargs, too.

@Ian-Foote
Ian-Foote Nov 2, 2014 Collaborator

👍

@meshy meshy self-assigned this Nov 2, 2014
@meshy Use kwargs for calls to elementree 58d3a57
@meshy
Owner
meshy commented Oct 19, 2015

Updated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment