Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D: strip unsupported -D (and -f) flags for ldc2 #5369

Closed
valpackett opened this issue May 7, 2019 · 1 comment
Closed

D: strip unsupported -D (and -f) flags for ldc2 #5369

valpackett opened this issue May 7, 2019 · 1 comment

Comments

@valpackett
Copy link
Contributor

Building tilix on FreeBSD, where the x11 pkgconf file contains a define flag:

% cat /usr/local/libdata/pkgconfig/x11.pc
[…]
Cflags: -I${includedir} -D_THREAD_SAFE
[1/63] ldc2 -I=tilix@exe -I=. -I=.. -I=../source/ -I=data -I/usr/local/include/d/gtkd-3/ -I/usr/local/include -enable-color -wi -release -enable-inlining -Hkeep-all-bodies -O3 -D_THREAD_SAFE -vcolumns -d-version=StdLoggerDisableTrace  -of='tilix@exe/source_secretc_secret.d.o' -c ../source/secretc/secret.d
FAILED: tilix@exe/source_secretc_secret.d.o
ldc2 -I=tilix@exe -I=. -I=.. -I=../source/ -I=data -I/usr/local/include/d/gtkd-3/ -I/usr/local/include -enable-color -wi -release -enable-inlining -Hkeep-all-bodies -O3 -D_THREAD_SAFE -vcolumns -d-version=StdLoggerDisableTrace  -of='tilix@exe/source_secretc_secret.d.o' -c ../source/secretc/secret.d
ldc2: Unknown command line argument '-D_THREAD_SAFE'.  Try: 'ldc2 -help'
ldc2: Did you mean '-pre-RA-sched'?

I guess such flags should be just removed…

Also, FreeBSD Ports sets up LDFLAGS for C/C++, and meson ends up passing unsupported flags to ldc2 here as well:

ldc2: Unknown command line argument '-fstack-protector-strong'.  Try: 'ldc2 -help'
ldc2: Did you mean '-stack-symbol-ordering'?
@valpackett
Copy link
Contributor Author

ping

valpackett added a commit to valpackett/meson that referenced this issue Jul 10, 2019
valpackett added a commit to DankBSD/ports that referenced this issue Jul 11, 2019
valpackett added a commit to DankBSD/ports that referenced this issue Jul 18, 2019
valpackett added a commit to DankBSD/ports that referenced this issue Jul 25, 2019
valpackett added a commit to DankBSD/ports that referenced this issue Jul 28, 2019
valpackett added a commit to DankBSD/ports that referenced this issue Aug 8, 2019
valpackett added a commit to DankBSD/ports that referenced this issue Aug 9, 2019
valpackett added a commit to DankBSD/ports that referenced this issue Aug 28, 2019
valpackett added a commit to DankBSD/ports that referenced this issue Sep 3, 2019
valpackett added a commit to DankBSD/ports that referenced this issue Sep 3, 2019
valpackett added a commit to DankBSD/ports that referenced this issue Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant