Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TAP implementation issue #6810

Open
matthiasclasen opened this issue Mar 20, 2020 · 2 comments
Open

TAP implementation issue #6810

matthiasclasen opened this issue Mar 20, 2020 · 2 comments

Comments

@matthiasclasen
Copy link

Describe the bug

The TAP protocol states:
Any output line that is not a version, a plan, a test line, a diagnostic or a bail out is considered an “unknown” line. A TAP parser is required to not consider an unknown line as an error

Yet, the meson TAP parser does:
yield self.Error('unexpected input at line %d' % (lineno,))

@dcbaker
Copy link
Member

dcbaker commented Mar 23, 2020

It might make sense to have a warning here instead, but either way this should be pretty easy for someone to fix.

@bonzini
Copy link
Contributor

bonzini commented Apr 20, 2020

Duplicate of #5944. Copying from there:

The part of the specification you quoted continues "... but may optionally choose to capture said line and hand it to the test harness, which may have custom behavior attached [...] TAP::Harness reports TAP syntax errors at the end of a test run".

In mtest, the TAP parser and harness are unified. It is possible to introduce an Unexpected namedtuple in the TAP parser if desired, so that we only report TAP syntax errors at the end of the test run, rather than exit as soon as they happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants