Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnome.yelp symlinks are absolute rather than relative to the prefix which breaks 'ninja dist' #7034

Closed
aruiz opened this issue Apr 25, 2020 · 0 comments · Fixed by #9557
Closed
Labels

Comments

@aruiz
Copy link

aruiz commented Apr 25, 2020

Describe the bug
When doing 'ninja dist' the check stage tries to change the permissions of each installed file, doing so on a symlink for each locale of the gnome.yelp help output. The installed prefix is whithn the build/ directory but the symlink points to /usr/local so the chmod operation throws an exception.

To Reproduce
Run ninja dist on a module that outputs docs using gnome.yelp

Expected behavior
For the dist to succeed and symlinks to be relative to the install prefix or the docs directory even

system parameters
This is fedora running on x86_64 doing a standard meson build && ninja -C build/ dist

[1030][aruiz@localhost ~]$ meson --version
0.54.0
[1031][aruiz@localhost ~]$ python3 --version
Python 3.8.2
[1032][aruiz@localhost ~]$ ninja --version
1.10.0
[1033][aruiz@localhost ~]$ yelp --version
yelp 3.36.0
@dcbaker dcbaker added the gnome label Apr 30, 2020
pabloyoyoista added a commit to pabloyoyoista/meson that referenced this issue Dec 11, 2021
This is basically a rewrite of the gnome.yelp target to remove the
ad-hoc script, which generates multiple issues, including meson
not knowing which files were installed.

Closes mesonbuild#7653
Closes mesonbuild#9539
Closes mesonbuild#6916
Closes mesonbuild#2775
Closes mesonbuild#7034
Closes mesonbuild#1052

Related mesonbuild#9105
Related mesonbuild#1601
Dudemanguy pushed a commit to Dudemanguy/meson that referenced this issue Jan 21, 2022
This is basically a rewrite of the gnome.yelp target to remove the
ad-hoc script, which generates multiple issues, including meson
not knowing which files were installed.

Closes mesonbuild#7653
Closes mesonbuild#9539
Closes mesonbuild#6916
Closes mesonbuild#2775
Closes mesonbuild#7034
Closes mesonbuild#1052

Related mesonbuild#9105
Related mesonbuild#1601
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants