Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

configure_file(): Allow multiple inputs in command mode #5895

Merged
merged 1 commit into from Sep 17, 2019
Merged

configure_file(): Allow multiple inputs in command mode #5895

merged 1 commit into from Sep 17, 2019

Conversation

xclaesse
Copy link
Member

@xclaesse xclaesse commented Sep 6, 2019

No description provided.

@xclaesse xclaesse force-pushed the configure_file_input branch 2 times, most recently from db5e273 to 953c4c1 Compare September 6, 2019 23:16
@jpakkane
Copy link
Member

jpakkane commented Sep 7, 2019

How does this compare to #5701?

@xclaesse
Copy link
Member Author

xclaesse commented Sep 7, 2019

Oh totally forgot we already had a patch for this. The other pr is very similar, afaict small differences are:

  • my patch fix crash when having files objects in the command and no input kwarg.
  • my patch adds files objects from command to build_def_files, that removes an old FIXME.

@xclaesse xclaesse mentioned this pull request Sep 10, 2019
Closed
@jpakkane
Copy link
Member

As a feature this is ok. I have not read through the code but if someone else does and finds it good, feel free to merge.

dcbaker
dcbaker approved these changes Sep 17, 2019
View reviewed changes
Copy link
Member

@dcbaker dcbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one very small nit, otherwise the code looks good to me. Since Jussi is happy with the feature with that one very small change I think this can go in.

test cases/common/14 configure file/check_inputs.py Outdated Show resolved Hide resolved
@xclaesse xclaesse merged commit ef3992f into mesonbuild:master Sep 17, 2019
@xclaesse xclaesse deleted the configure_file_input branch September 17, 2019 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ignatenkobrain ignatenkobrain ignatenkobrain left review comments

@dcbaker dcbaker dcbaker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@xclaesse @jpakkane @dcbaker @ignatenkobrain