Rework run_target to mirror custom_target. #618

Merged
merged 3 commits into from Jul 1, 2016

Conversation

Projects
None yet
2 participants
@jpakkane
Member

jpakkane commented Jun 24, 2016

No description provided.

Changed run_target to take command as kwarg and add depends. This mak…
…es it behave the same as custom_target.

@jpakkane jpakkane referenced this pull request Jun 24, 2016

Closed

Arduino? #612

@nirbheek

This comment has been minimized.

Show comment
Hide comment
@nirbheek

nirbheek Jun 25, 2016

Member

How about merging the ninja implementations of the two? Now the two do basically the same thing under the hood. generate_custom_target and generate_run_target look very similar, and scripts/commandrunner.py and scripts/meson_exe.py can easily be merged into one script.

Related: #546

Member

nirbheek commented Jun 25, 2016

How about merging the ninja implementations of the two? Now the two do basically the same thing under the hood. generate_custom_target and generate_run_target look very similar, and scripts/commandrunner.py and scripts/meson_exe.py can easily be merged into one script.

Related: #546

@jpakkane

This comment has been minimized.

Show comment
Hide comment
@jpakkane

jpakkane Jul 1, 2016

Member

Merged some of the common code.

Member

jpakkane commented Jul 1, 2016

Merged some of the common code.

@jpakkane jpakkane merged commit cc775d6 into master Jul 1, 2016

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@jpakkane jpakkane deleted the rtrehaul branch Jul 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment