C++ module support #8013
Merged
C++ module support #8013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 1 alert when merging 12952c4 into 15bbf1e - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 6686bcf into b65168c - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 9731b0e into b65168c - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 07c70e7 into 8d04b3c - view on LGTM.com new alerts:
|
jpakkane
force-pushed
the
cppmodules
branch
2 times, most recently
from
ca808a0
to
ba725f0
Compare
|
This should pass all the tests now. The actual functionality is fairly small, but the machinery is important and can be used to make Fortran compilation finally reliable. |
jpakkane
force-pushed
the
cppmodules
branch
2 times, most recently
from
aab28fa
to
2fafb73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This MR adds support for compiling C++ modules, which are similar to Fortran modules requiring one to scan the contents of files. This is done with the new Ninja dynamic dependency support that is only available in the latest releases. There are several limitations.
There are also open questions such as where should the generated module files go. Should they go in target private dirs or to a single common dir? The latter is easier and works if we can rely on the fact that no module of a given name is generated in two different places. Currently all those are dumped in build dir root, because MS has not yet documented the compiler flags that specify where those should go (if said compiler flags exist at all).