gnome: Add post_install() method #8272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC @ebassi See corresponding MR in gtk4: https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/3135 |
|
Also need a patch in glib in case it's a subproject: https://gitlab.gnome.org/GNOME/glib/-/merge_requests/1909. |
gnomesysadmins
pushed a commit
to GNOME/glib
that referenced
this pull request
Jan 30, 2021
It is going to be used in Meson's gnome module, and if glib is built as subproject it's better to use it. See mesonbuild/meson#8272.
xclaesse
force-pushed
the
gnome-install-script
branch
from
fd3b1ed
to
9e31fa9
Compare
|
I don't know enough about Gnome internals to say anything about the UX but featurewise looks good. |
xclaesse
force-pushed
the
gnome-install-script
branch
from
9e31fa9
to
3760fee
Compare
Various GNOME projects have scripts that does similar task, better do it directly in meson. This ensures it's done correctly regarding usage of subprojects and pkg-config. See for example this gtk bug: https://gitlab.gnome.org/GNOME/gtk/-/issues/3626. Fixes: mesonbuild#8268
xclaesse
force-pushed
the
gnome-install-script
branch
from
3760fee
to
bcdec4d
Compare
xclaesse
changed the title
|
I decided to rename the method to |
@ebassi could validate the idea maybe? |
Closed
eli-schwartz
approved these changes
Feb 5, 2021
|
I am not @mclasen. Please remove
Michael Clasen
Mclasen@mclasen.com
Mclasen@gmail.com
Thanks
Sent from my iPhone 6+
… On Feb 5, 2021, at 12:09 PM, Xavier Claessens ***@***.***> wrote:
Merged #8272 into master.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
That was for @matthiasclasen, sorry. |
gnomesysadmins
pushed a commit
to GNOME/gtk
that referenced
this pull request
Mar 22, 2021
This was referenced Sep 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various GNOME projects have scripts that does similar task, better do it directly in meson. This ensures it's done correctly regarding usage of subprojects and pkg-config. See for example this gtk bug:
https://gitlab.gnome.org/GNOME/gtk/-/issues/3626.
Fixes: #8268