introspect: include choices for array options #9395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Adding @mensinda too. |
Codecov Report
@@ Coverage Diff @@
## master #9395 +/- ##
=======================================
Coverage 67.29% 67.29%
=======================================
Files 396 396
Lines 85412 85416 +4
Branches 17481 17483 +2
=======================================
+ Hits 57475 57480 +5
- Misses 23243 23246 +3
+ Partials 4694 4690 -4
Continue to review full report at Codecov.
|
There was even a test covering this, but it did not fail due to a typo.
bonzini
force-pushed
the
introspect-array-choices
branch
from
c1be12c
to
2d7ded8
Compare
|
The failures are due to internal issues in GitHub and Azure. |
|
I am adding this to 0.60.0 since this looks more like a bug fix since there was/is a broken test case. |
bonzini
added a commit
to qemu/qemu
that referenced
this pull request
Oct 14, 2021
Manually patch the introspection data to include the tracing backends. This works around a deficiency in Meson that will be fixed by mesonbuild/meson#9395. Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
duskmoon314
pushed a commit
to duskmoon314/qemu
that referenced
this pull request
Oct 23, 2021
Manually patch the introspection data to include the tracing backends. This works around a deficiency in Meson that will be fixed by mesonbuild/meson#9395. Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was even a test covering this, but it did not fail due to a typo.