Timezone support? #11

Closed
victorhooi opened this Issue Mar 19, 2013 · 5 comments

Comments

Projects
None yet
4 participants

Hi,

I didn't see anything in the configuration or docs about specifying a timezone.

Is it possible to configure timezones for jobs?

(Say if you had jobs that were spread across machines in several colos in different timezones).

Cheers,
Victor

Contributor

florianleibert commented Mar 20, 2013

Hi Victor,
this is currently not supported - I suspect it would be a 20 minute fix however to expose this in the configuration file!

Specifically, all that needs to happen is replace all occurrences (and this is why we specified the TimeZone in every getDateTime statement) by the a configuration variable in the SchedulerConfiguration.scala file.

If you wrote code for it and added a unit test, I'd be super happy to merge the changes in - otherwise it may be a while before I get to it!

Thanks,
Florian

heya,

Hmm, I was actually referring to a timezone associated with every job, actually - is that different to what your'e describing?

Cheers,
Victor

Contributor

andykram commented Mar 20, 2013

As mentioned in the beginning of README.md and in the Adding a Schedule Job section, Chronos supports ISO8601 expressions for scheduling jobs. Wikipedia has a great guide to ISO8601, if you're not familiar with it.

When it comes to specific timezones, I believe you'd want to reference the section on Time zone designators. That said, here at Airbnb, we prefer to keep it simple, and use UTC (Z) almost exclusively.

Contributor

mbautin commented Apr 29, 2014

ISO8601 is quite flexible, but it does not support specifying a schedule running in a local timezone, e.g. 6am U.S. Eastern Time ("ET"), which would correspond to 10am UTC during summer (EDT timezone) or 11am UTC during winter (EST timezone). Is there a plan to add support for such local timezones to Chronos?

Contributor

florianleibert commented Apr 29, 2014

Not at the moment. We'd happily accept a patch if you were to dive in and
try to add support with proper test cases.

Thanks.

On Tue, Apr 29, 2014 at 2:31 PM, Mikhail Bautin notifications@github.comwrote:

ISO8601 is quite flexible, but it does not support specifying a schedule
running in a local timezone, e.g. 6am U.S. Eastern Time ("ET"), which
would correspond to 10am UTC during summer (EDT timezone) or 11am UTC
during winter (EST timezone). Is there a plan to add support for such local
timezones to Chronos?


Reply to this email directly or view it on GitHubhttps://github.com/airbnb/chronos/issues/11#issuecomment-41734973
.


t: http://twitter.com/flo
s: florianleibert

l: http://www.linkedin.com/in/florianleibert/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment