proto: bump to 1.6.x 2f6f381 #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chhsia0
force-pushed
the
bump-1.6.x-2f6f381
branch
2 times, most recently
from
82ed45f
to
e3a9d93
Compare
chhsia0
force-pushed
the
bump-1.6.x-2f6f381
branch
from
e3a9d93
to
ec04a93
Compare
jdef
reviewed
Jul 19, 2018
| @@ -239,7 +239,8 @@ message Response { | |||
| repeated OperationStatus operation_statuses = 1 [(gogoproto.nullable) = false]; | |||
| } | |||
|
|
|||
| optional ReconcileOperations reconcile_operations = 1; | |||
| optional Type type = 1 [(gogoproto.nullable) = false]; | |||
There was a problem hiding this comment.
this tag change is unfortunate but aligns perfectly w/ upstream changes
There was a problem hiding this comment.
I checked with Gaston and confirmed that this was not used anywhere when introduced, so it should be a "safe" change.
jdef
reviewed
Jul 19, 2018
api/v1/lib/master/calls/calls.go
Outdated
| @@ -221,6 +228,32 @@ func DestroyVolumes(a mesos.AgentID, v ...mesos.Resource) *master.Call { | |||
| } | |||
| } | |||
|
|
|||
| // GrowLocalVolume grows a persistent volume on an agent's ROOT or PATH disks. The request is forwarded asynchronously | |||
| // to the Mesos agent where the persistent volume is located. | |||
| func GrowLocalVolume(a mesos.AgentID, volume mesos.Resource, addition mesos.Resource) *master.Call { | |||
There was a problem hiding this comment.
nit: it's more idiomatic to say volume, addition mesos.Resource (since they've of the same type)
There was a problem hiding this comment.
also: mesos.AgentID is optional in the protos, so it should be a pointer here
jdef
reviewed
Jul 19, 2018
api/v1/lib/master/calls/calls.go
Outdated
|
|
||
| // ShrinkLocalVolume shrinks a persistent volume on an agent's ROOT or PATH disks. The request is forwarded | ||
| // asynchronously to the Mesos agent where the persistent volume is located. | ||
| func ShrinkLocalVolume(a mesos.AgentID, volume mesos.Resource, subtract mesos.Value_Scalar) *master.Call { |
There was a problem hiding this comment.
mesos.AgentID is optional in protos, should be a pointer parameter
There was a problem hiding this comment.
I'll make it a pointer. Then should I just rename it to GrowVolume/ShrinkVolume? Currently it supports only local volumes but me may extend it to support external volumes in the future.
|
Thanks, left some feedback. Surprised that schedulerpb_test.go didn't have any changes |
|
I'm fine w/ GrowVolume/ShrinkVolume
…On Thu, Jul 19, 2018 at 1:56 PM Chun-Hung Hsiao ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In api/v1/lib/master/calls/calls.go
<#354 (comment)>:
> +// GrowLocalVolume grows a persistent volume on an agent's ROOT or PATH disks. The request is forwarded asynchronously
+// to the Mesos agent where the persistent volume is located.
+func GrowLocalVolume(a mesos.AgentID, volume mesos.Resource, addition mesos.Resource) *master.Call {
+ return &master.Call{
+ Type: master.Call_GROW_VOLUME,
+ GrowVolume: &master.Call_GrowVolume{
+ AgentID: &a,
+ Volume: volume,
+ Addition: addition,
+ },
+ }
+}
+
+// ShrinkLocalVolume shrinks a persistent volume on an agent's ROOT or PATH disks. The request is forwarded
+// asynchronously to the Mesos agent where the persistent volume is located.
+func ShrinkLocalVolume(a mesos.AgentID, volume mesos.Resource, subtract mesos.Value_Scalar) *master.Call {
I'll make it a pointer. Then should I just rename it to GrowVolume/
ShrinkVolume? Currently it supports only local volumes but me may extend
it to support external volumes in the future.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#354 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ACPVLNWkO781DWvBzb6AXsMFyIrFHC3Xks5uIMhSgaJpZM4VVail>
.
|
chhsia0
force-pushed
the
bump-1.6.x-2f6f381
branch
from
ca7d0a4
to
c11ae24
Compare
|
@jdef Done. PTAL. |
jdef
approved these changes
Jul 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated Mesos protos to 1.6.x, which adds a new master call for GET_OPERATIONS, and new agent calls for GET_OPERATIONS, GROW_VOLUME and SHRINK_VOLUME. For the latter two, only agent-local volumes are supported.