Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kommander] crd fix (part 1) #237

Merged
merged 4 commits into from Nov 6, 2019

Conversation

@alejandroEsc
Copy link
Member

alejandroEsc commented Nov 6, 2019

This PR is following the solution to fixing crd installation problems encountered when trying to deploy/upgrade a chart given existing crds. It also functionally attempts to update crds if so required.

part 1 of 2. Second part would include pulling in a new kubefed chart that contains fixes for those CRDs.

@alejandroEsc alejandroEsc self-assigned this Nov 6, 2019
@alejandroEsc alejandroEsc requested review from s12chung and joejulian Nov 6, 2019
@alejandroEsc alejandroEsc added the wip label Nov 6, 2019
alejandroEsc added 4 commits Nov 5, 2019
…ted ones
@jimmidyson jimmidyson force-pushed the ae/kommander/crd1 branch from f825dcf to c72cd20 Nov 6, 2019
@jimmidyson jimmidyson requested review from hectorj2f and jimmidyson Nov 6, 2019
@alejandroEsc alejandroEsc added ready and removed wip labels Nov 6, 2019
@alejandroEsc alejandroEsc changed the title [kommander] crd fix [kommander] crd fix (part 1) Nov 6, 2019
@jimmidyson

This comment has been minimized.

Copy link
Member

jimmidyson commented Nov 6, 2019

We can get rid of observable cluster, confirmed with UI team.

@alejandroEsc

This comment has been minimized.

Copy link
Member Author

alejandroEsc commented Nov 6, 2019

We can get rid of observable cluster, confirmed with UI team.

awesome, if that is the case let me update the chart items.

@jimmidyson

This comment has been minimized.

Copy link
Member

jimmidyson commented Nov 6, 2019

I think we can also get rid of the separate enablement of different federated resources, they should always all be enabled.

@alejandroEsc

This comment has been minimized.

Copy link
Member Author

alejandroEsc commented Nov 6, 2019

I think we can also get rid of the separate enablement of different federated resources, they should always all be enabled.

sounds ok, i will do so in a follow pr

@alejandroEsc alejandroEsc merged commit 1ed0d1b into dev Nov 6, 2019
1 check passed
1 check passed
Chart PR Finished TeamCity Build Mesosphere Only :: Closed Source :: Konvoy :: Chart PR : Running
Details
@alejandroEsc alejandroEsc deleted the ae/kommander/crd1 branch Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.