From 4716e7ffdf5efdecfd3c129ab8fdc3c62d4c2a28 Mon Sep 17 00:00:00 2001 From: Julien Bonjean Date: Wed, 25 Jan 2017 16:22:48 -0500 Subject: [PATCH] Fix app update for marathon 1.4.x Since Marathon 1.4.x, it seems that app versions are not returned in a specific order, but some of the logic in marathon-ui relies on it. This is fixed by sorting the versions list received in descending order, as it was returned by previous Marathon versions. --- src/js/stores/AppVersionsStore.js | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/src/js/stores/AppVersionsStore.js b/src/js/stores/AppVersionsStore.js index 5d12b0e2d..5c8209f84 100644 --- a/src/js/stores/AppVersionsStore.js +++ b/src/js/stores/AppVersionsStore.js @@ -41,7 +41,16 @@ var AppVersionsStore = Util.extendObject(EventEmitter.prototype, { getAppVersions: function (appId) { if (appId === storeData.currentAppId) { - return this.availableAppVersions; + return this.availableAppVersions + .sort(function (a, b) { + if (a < b) { + return 1; + } + if (a > b) { + return -1; + } + return 0; + }); } return []; },