Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of the Modal/lightbox #810

Closed
mlunoe opened this Issue Nov 19, 2014 · 4 comments

Comments

Projects
None yet
4 participants
@mlunoe
Copy link
Contributor

mlunoe commented Nov 19, 2014

Get rid of the Modal/lightbox

In marathon the modal was introduced early on, but have since been filled with A LOT of content. It doesn't really makes sense to have this anymore, so let's get rid of if. Take contents of the modal and move it out to a single page, so it looks something like this:

Task list
Task details

@iven

This comment has been minimized.

Copy link
Contributor

iven commented Nov 25, 2014

Better use left arrow(←) instead of close button(x)?

@mlunoe

This comment has been minimized.

Copy link
Contributor Author

mlunoe commented Nov 25, 2014

Yeah, something like that, or better yet, make the header /my-app breadcrumbs, so it looks something like this: Apps > /my-app. These could then incorporate the breadcrumbs in the task layer as well (so we don't have double breadcrumbs):

Apps > /my-app > my-app.4fbdceb2-5937-11e4-995a-56847afe9799

@aldipower

This comment has been minimized.

Copy link
Contributor

aldipower commented Feb 2, 2015

@mlunoe I've tried to implement the breadcrumbs Apps > /my-app, but decided not to integrate it into #1123 because it looks a little bit messy. I can show you this in a separate branch, if you like.

@mlunoe

This comment has been minimized.

Copy link
Contributor Author

mlunoe commented Feb 3, 2015

@aldipower: Yes, it would be great to see it in a separate branch

@aldipower aldipower closed this Feb 12, 2015

@mesosphere mesosphere locked and limited conversation to collaborators Mar 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.