Releases/1.3 async task tracker #4912

Merged
merged 9 commits into from Jan 2, 2017

Conversation

Projects
None yet
6 participants
@janisz
Contributor

janisz commented Dec 28, 2016

It looks like Marathon 1.4 needs more time to be production ready. I prepared a PR that reflects critical changes made for 1.4 InstanceTracker and port it to 1.3 TaskTracker. With this changes threads count is more stable and keeps below 500.

Below you can see comparison between 1.3.6 before and after applying this patch (11:30 to 13:15).

async_vs_blocking_task_tracker

janisz and others added some commits Dec 16, 2016

Do not block during reconciliation of health checks.
The MarathonHealthCheckManager used the sync version of the
InstanceTracker.
Handle spaces in arguments correctly.
Test Plan: Start marathon via this script with spaces in arguments.

Reviewers: lukas, jeschkies

Reviewed By: lukas, jeschkies

Subscribers: jenkins, marathon-team

Differential Revision: https://phabricator.mesosphere.com/D324
@review-ninja

This comment has been minimized.

Show comment
Hide comment
@mesosphere-ci

This comment has been minimized.

Show comment
Hide comment
@mesosphere-ci

mesosphere-ci Dec 28, 2016

Collaborator

Can one of the admins verify this patch?

Collaborator

mesosphere-ci commented Dec 28, 2016

Can one of the admins verify this patch?

@mesosphere-ci

This comment has been minimized.

Show comment
Hide comment
@mesosphere-ci

mesosphere-ci Dec 28, 2016

Collaborator

Can one of the admins verify this patch?

Collaborator

mesosphere-ci commented Dec 28, 2016

Can one of the admins verify this patch?

@aquamatthias

This comment has been minimized.

Show comment
Hide comment
@aquamatthias

aquamatthias Jan 2, 2017

Contributor

ok to test

Contributor

aquamatthias commented Jan 2, 2017

ok to test

@aquamatthias

@janisz Thanks

@jeschkies

Thanks.

@jeschkies jeschkies merged commit a05a01b into mesosphere:releases/1.3 Jan 2, 2017

2 of 4 checks passed

Velocity - Integration Tests 1466 tests run, 0 skipped, 0 failed.
Details
code-review/reviewninja 0 (of 1) ninja stars
Details
Velocity Build finished.
Details
Velocity - Package 1466 tests run, 0 skipped, 0 failed.
Details
@jeschkies

This comment has been minimized.

Show comment
Hide comment
@jeschkies

jeschkies Jan 2, 2017

Contributor

Integration tests do pass but the job fails because it tries to execute sbt scapegoat.

Contributor

jeschkies commented Jan 2, 2017

Integration tests do pass but the job fails because it tries to execute sbt scapegoat.

@janisz janisz deleted the janisz:releases/1.3_async_task_tracker branch Jan 3, 2017

@janisz janisz referenced this pull request Jan 18, 2017

Closed

Create Marathon 1.3.7 #4925

@marcomonaco marcomonaco added the pr label Mar 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment