Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend the set of command-line flags returned by /v2/info #5612

Merged
merged 1 commit into from Oct 17, 2017
Merged

Extend the set of command-line flags returned by /v2/info #5612

merged 1 commit into from Oct 17, 2017

Conversation

ichernetsky
Copy link
Contributor

No description provided.

mesosphere-ci
mesosphere-ci requested changes Oct 13, 2017
View reviewed changes
Copy link
Collaborator

@mesosphere-ci mesosphere-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm building your change at jenkins-marathon-pipelines-PR-5612-1.

mesosphere-ci
mesosphere-ci approved these changes Oct 13, 2017
View reviewed changes
Copy link
Collaborator

@mesosphere-ci mesosphere-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔ Build of #5612 completed successfully.

See details at jenkins-marathon-pipelines-PR-5612-1.

You can create a DC/OS with your patched Marathon by creating a new pull
request with the following changes in buildinfo.json:

"url": "https://s3.amazonaws.com/downloads.mesosphere.io/marathon/snapshots/marathon-1.5.1-17-gef3e93e.tgz",
"sha1": "aff4c3e8273577cd21f885e431f850a1b52aad0a"

＼\ ٩( ᐛ )و /／

alenkacz
alenkacz suggested changes Oct 15, 2017
View reviewed changes
Copy link
Contributor

@alenkacz alenkacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

model these new fields in RAML ... ?

@ichernetsky
Copy link
Contributor Author

@alenkacz why do you think it would be nice to do? /v2/info supports only GET method.

alenkacz
alenkacz reviewed Oct 17, 2017
View reviewed changes
Copy link
Contributor

@alenkacz alenkacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if it is not that thing in RAML (https://mesosphere.github.io/marathon/api-console/index.html) then OK

@jeschkies
Copy link
Contributor

I agree with @alenkacz. For master we have to add the fields to the RAML. However, they do not exist for 1.4 and 1.5.

@jeschkies jeschkies merged commit 0c03b1a into releases/1.5 Oct 17, 2017
@ichernetsky ichernetsky deleted the ic/1.5-v2-info branch October 17, 2017 16:12
@ichernetsky
Copy link
Contributor Author

ichernetsky commented Oct 17, 2017 •
edited

@jeschkies I don't get what the benefit is of having a RAML type for JSON objects returned by /v2/info? Am I missing something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timcharper timcharper timcharper approved these changes

@kensipe kensipe kensipe approved these changes

@alenkacz alenkacz alenkacz approved these changes

@mesosphere-ci mesosphere-ci mesosphere-ci approved these changes

@meln1k meln1k Awaiting requested review from meln1k

@jeschkies jeschkies Awaiting requested review from jeschkies

@zen-dog zen-dog Awaiting requested review from zen-dog

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ichernetsky @jeschkies @timcharper @kensipe @alenkacz @mesosphere-ci