Skip to content

Add machineTimeout parameter #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sotoz merged 2 commits into from
Apr 6, 2017
Merged

Add machineTimeout parameter #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f4a0d9
Add `machineTimeout` parameter
Apr 5, 2017
56e4ca2
Version bump
Apr 5, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/MessageBird/Client.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ class Client
const ENDPOINT = 'https://rest.messagebird.com';
const CHATAPI_ENDPOINT = 'https://chat.messagebird.com/1';

const CLIENT_VERSION = '1.6.5';
const CLIENT_VERSION = '1.6.6';

/**
* @var string
Expand Down
8 changes: 8 additions & 0 deletions src/MessageBird/Objects/VoiceMessage.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,14 @@ class VoiceMessage extends Base
*/
public $ifMachine = 'continue';

/**
* The time (in milliseconds) to analyze if a machine has picked up the phone. Used in combination with the delay
* and hangup values of the ifMachine attribute. Minimum: 400, maximum: 10000.
*
* @var int
*/
public $machineTimeout = 7000;

/**
* The scheduled date and time of the message in RFC3339 format (Y-m-d\TH:i:sP)
*
Expand Down
2 changes: 1 addition & 1 deletion tests/integration/voicemessages/VoiceMessagesTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ public function testVoiceMessageCreate()
$Message->body = 'This is a test message.';
$Message->language = "nl";
$Message->voice = "male";
$this->mockClient->expects($this->once())->method('performHttpRequest')->with("POST", 'voicemessages', null, '{"originator":"MessageBird","body":"This is a test message.","reference":null,"language":"nl","voice":"male","repeat":1,"ifMachine":"continue","scheduledDatetime":null,"recipients":[31612345678],"reportUrl":null}');
$this->mockClient->expects($this->once())->method('performHttpRequest')->with("POST", 'voicemessages', null, '{"originator":"MessageBird","body":"This is a test message.","reference":null,"language":"nl","voice":"male","repeat":1,"ifMachine":"continue","machineTimeout":7000,"scheduledDatetime":null,"recipients":[31612345678],"reportUrl":null}');
$this->client->voicemessages->create($Message);
}

Expand Down