Skip to content

Added support for Contacts and Groups #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Oct 4, 2017
Merged

Added support for Contacts and Groups #45

merged 19 commits into from
Oct 4, 2017

Conversation

@sotoz
Copy link
Contributor

@sotoz sotoz commented Apr 10, 2017

This PR enables the php-rest-api library to support Contacts and Groups management. It also includes examples of all actions (create/delete/update etc) that are currently supported by the Rest API.

@sotoz sotoz added the feature label Apr 10, 2017
@dstotijn dstotijn mentioned this pull request Sep 5, 2017
Merged
@sotoz sotoz requested review from dstotijn and samwierema September 5, 2017 15:29
@Dirk94
Copy link

Dirk94 commented Sep 18, 2017

contacts->getGroups() returns an array of Contacts instead of an array of Groups. Working on the fix & a new test for this.

Dirk Hoekstra and others added 14 commits September 18, 2017 18:03
Fixed contacts getGroups and getMessages response.
9779df9
Added contact getGroups and contact getMessages tests
d7cb298
Set dist to precise
49beb40
php hhvm should use trusty dist
8011787
set composer prefer-lowest flag for hhvm build
1124dda
allow hhvm to fail
d2fec44
add hhvm to build jobs
c86efe0
@samwierema
Merge pull request #51 from messagebird/travis-config-fix
c96fa90 
Set distribution in travis config to precise
Added Contacts and Groups functionality
9dd2d58
Fixed examples, added functionality for removing a contact from a group
c3ff0cf
Use getList() to fetch contacts/messages for groups
1143dfc
Fixed contacts getGroups and getMessages response.
5999e9d
Added contact getGroups and contact getMessages tests
1f4be9b
Merge branch 'contacts-groups' of github.com:sotoz/php-rest-api into …
2c6b10c 
…contacts-groups
@samwierema
Copy link
Contributor

samwierema commented Sep 20, 2017

@sotoz can you do a review of all changes since this week?

@samwierema samwierema merged commit 660cf90 into messagebird:master Oct 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samwierema samwierema Awaiting requested review from samwierema

@dstotijn dstotijn Awaiting requested review from dstotijn

Assignees

No one assigned

Labels

feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sotoz @Dirk94 @samwierema @mrdm-nl