New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add imgur api service #2

Merged
merged 1 commit into from Feb 3, 2019

Conversation

Projects
None yet
2 participants
@messeb
Copy link
Owner

messeb commented Feb 3, 2019

No description provided.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 3, 2019

Codecov Report

Merging #2 into master will decrease coverage by 2.04%.
The diff coverage is 97.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #2      +/-   ##
==========================================
- Coverage     100%   97.95%   -2.05%     
==========================================
  Files           2       11       +9     
  Lines          22       98      +76     
==========================================
+ Hits           22       96      +74     
- Misses          0        2       +2
Impacted Files Coverage Δ
Service/Service/Network/Resource.swift 100% <100%> (ø)
...ervice/Service/Network/URLResponse+Extension.swift 100% <100%> (ø)
...ce/Service/Network/HTTPURLResponse+Extension.swift 100% <100%> (ø)
...e/Service/Repositories/ImgurImagesRepository.swift 100% <100%> (ø)
Service/Service/Network/Resource+Extension.swift 100% <100%> (ø)
Service/Service/Models/ImgurImage.swift 100% <100%> (ø)
Service/Service/Models/ImgurGallery.swift 100% <100%> (ø)
Service/Service/Network/Reactive+Extension.swift 90.9% <90.9%> (ø)
Service/Service/Network/Webservice.swift 93.33% <93.33%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4dd02aa...10931db. Read the comment docs.

@messeb messeb merged commit d8566ae into master Feb 3, 2019

6 of 7 checks passed

codecov/patch 97.36% of diff hit (target 100%)
Details
Hound 4 violations found.
codecov/project/core 100% remains the same compared to dd69173
Details
codecov/project/ios 100% remains the same compared to dd69173
Details
codecov/project/service 100% remains the same compared to dd69173
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
danger/danger All green. Yay.

@messeb messeb deleted the feature/2_imgur_api-service branch Feb 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment