Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gallery section #3

Merged
merged 3 commits into from Mar 3, 2019

Conversation

Projects
None yet
2 participants
@messeb
Copy link
Owner

messeb commented Mar 3, 2019

No description provided.

static let clientId = "a0f70f5015d9134"

static let infoItems = [
AboutInfo(name: "Version", value: Bundle.main.object(forInfoDictionaryKey: kCFBundleVersionKey as String) as? String),

This comment has been minimized.

@houndci-bot

houndci-bot Mar 3, 2019

Line Length Violation: Line should be 120 characters or less: currently 126 characters (line_length)

@@ -11,7 +11,7 @@ final class ImgurImageSpec: QuickSpec {
context("a valid image id is given") {
it("returns a url for the image") {
let imageId = "4711"
let expectedImageUrlPath = "https://i.imgur.com/\(imageId).jpg"
let expectedImageUrlPath = "https://i.imgur.com/\(imageId).jpg?maxwidth=120&shape=thumb&fidelity=low"

This comment has been minimized.

@houndci-bot

houndci-bot Mar 3, 2019

Line Length Violation: Line should be 120 characters or less: currently 121 characters (line_length)

@@ -1,12 +1,18 @@
import Foundation

private struct SubImage: Codable {
let id: String

This comment has been minimized.

@houndci-bot

houndci-bot Mar 3, 2019

Identifier Name Violation: Variable name should be between 3 and 40 characters long: 'id' (identifier_name)


viewModel.load.onNext(true)

expect(dataSource?.collectionView(sut.collectionView, numberOfItemsInSection: 0)).toEventually(equal(expectedImagesCount))

This comment has been minimized.

@houndci-bot

houndci-bot Mar 3, 2019

Line Length Violation: Line should be 120 characters or less: currently 138 characters (line_length)


outputs.images
.drive(collectionView.rx
.items(cellIdentifier: ImgurImageCell.reuseIdentifier, cellType: ImgurImageCell.self)) { _, element, cell in

This comment has been minimized.

@houndci-bot

houndci-bot Mar 3, 2019

Line Length Violation: Line should be 120 characters or less: currently 124 characters (line_length)

}

public func cell<T: UICollectionViewCell>(of classType: T.Type, for indexPath: IndexPath) -> T {
guard let dequeuedCell = self.dequeueReusableCell(withReuseIdentifier: classType.reuseIdentifier, for: indexPath) as? T else {

This comment has been minimized.

@houndci-bot

houndci-bot Mar 3, 2019

Line Length Violation: Line should be 120 characters or less: currently 134 characters (line_length)

@codecov

This comment has been minimized.

Copy link

codecov bot commented Mar 3, 2019

Codecov Report

Merging #3 into master will decrease coverage by 23.96%.
The diff coverage is 66.07%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master       #3       +/-   ##
===========================================
- Coverage   97.95%   73.99%   -23.97%     
===========================================
  Files          11       33       +22     
  Lines          98      373      +275     
===========================================
+ Hits           96      276      +180     
- Misses          2       97       +95
Impacted Files Coverage Δ
...ore/Scenes/About/View/Cell/AboutItemCellView.swift 0% <0%> (ø)
...e/Core/Scenes/About/View/AboutViewController.swift 0% <0%> (ø)
...ore/Extensions/Storyboard/Storyboard+Dismiss.swift 0% <0%> (ø)
...ons/UITableView/UITableView+CellRegistration.swift 0% <0%> (ø)
...ore/Scenes/Gallery/View/Cells/ImgurImageCell.swift 100% <100%> (ø)
...ensions/UIViewController/UIViewController+Rx.swift 100% <100%> (ø)
Core/Core/Scenes/About/Model/AboutInfo.swift 100% <100%> (ø)
...ore/Core/Scenes/About/ViewModel/AboutUsecase.swift 100% <100%> (ø)
Core/Core/Scenes/App/AppCoordinator.swift 100% <100%> (ø)
...ore/Scenes/App/Factories/CoordinatingFactory.swift 100% <100%> (ø)
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b9b1d9...e5db56f. Read the comment docs.


outputs.images
.drive(collectionView.rx
.items(cellIdentifier: ImgurImageCell.reuseIdentifier, cellType: ImgurImageCell.self)) { _, element, cell in

This comment has been minimized.

@houndci-bot

houndci-bot Mar 3, 2019

Line Length Violation: Line should be 120 characters or less: currently 124 characters (line_length)

messeb added some commits Mar 3, 2019

@messeb messeb force-pushed the feature/3_show_gallery branch from b458e70 to e5db56f Mar 3, 2019

@messeb messeb merged commit 18c0463 into master Mar 3, 2019

6 of 7 checks passed

codecov/patch 66.07% of diff hit (target 97.95%)
Details
Hound 6 violations found.
codecov/project/core 100% remains the same compared to 7b9b1d9
Details
codecov/project/ios 100% remains the same compared to 7b9b1d9
Details
codecov/project/service 100% remains the same compared to 7b9b1d9
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
danger/danger All green. Congrats.

@messeb messeb deleted the feature/3_show_gallery branch Mar 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.