Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gallery tests #4

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@messeb
Copy link
Owner

messeb commented Mar 4, 2019

No description provided.

@@ -1,12 +1,18 @@
import Foundation

private struct SubImage: Codable {
let id: String

This comment has been minimized.

@houndci-bot

houndci-bot Mar 4, 2019

Identifier Name Violation: Variable name should be between 3 and 40 characters long: 'id' (identifier_name)

@@ -11,7 +11,7 @@ final class ImgurImageSpec: QuickSpec {
context("a valid image id is given") {
it("returns a url for the image") {
let imageId = "4711"
let expectedImageUrlPath = "https://i.imgur.com/\(imageId).jpg"
let expectedImageUrlPath = "https://i.imgur.com/\(imageId).jpg?maxwidth=120&shape=thumb&fidelity=low"

This comment has been minimized.

@houndci-bot

houndci-bot Mar 4, 2019

Line Length Violation: Line should be 120 characters or less: currently 121 characters (line_length)

return true
}
}

This comment has been minimized.

@houndci-bot

houndci-bot Mar 4, 2019

Trailing Newline Violation: Files should have a single trailing newline. (trailing_newline)


outputs.images
.drive(collectionView.rx
.items(cellIdentifier: ImgurImageCell.reuseIdentifier, cellType: ImgurImageCell.self)) { _, element, cell in

This comment has been minimized.

@houndci-bot

houndci-bot Mar 4, 2019

Line Length Violation: Line should be 120 characters or less: currently 124 characters (line_length)

}

public func cell<T: UICollectionViewCell>(of classType: T.Type, for indexPath: IndexPath) -> T {
guard let dequeuedCell = self.dequeueReusableCell(withReuseIdentifier: classType.reuseIdentifier, for: indexPath) as? T else {

This comment has been minimized.

@houndci-bot

houndci-bot Mar 4, 2019

Line Length Violation: Line should be 120 characters or less: currently 134 characters (line_length)

static let clientId = "<Needs a client id>"

static let infoItems = [
AboutInfo(name: "Version", value: Bundle.main.object(forInfoDictionaryKey: kCFBundleVersionKey as String) as? String),

This comment has been minimized.

@houndci-bot

houndci-bot Mar 4, 2019

Line Length Violation: Line should be 120 characters or less: currently 126 characters (line_length)


viewModel.load.onNext(true)

expect(dataSource?.collectionView(sut.collectionView, numberOfItemsInSection: 0)).toEventually(equal(expectedImagesCount))

This comment has been minimized.

@houndci-bot

houndci-bot Mar 4, 2019

Line Length Violation: Line should be 120 characters or less: currently 138 characters (line_length)

@messeb messeb force-pushed the feature/4_show_gallery_tests branch from 2441a98 to 899f2b5 Mar 4, 2019

@codecov

This comment has been minimized.

Copy link

codecov bot commented Mar 4, 2019

Codecov Report

Merging #4 into master will increase coverage by 12.39%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master       #4       +/-   ##
===========================================
+ Coverage   73.99%   86.39%   +12.39%     
===========================================
  Files          33       26        -7     
  Lines         373      294       -79     
===========================================
- Hits          276      254       -22     
+ Misses         97       40       -57
Impacted Files Coverage Δ
...re/Scenes/Gallery/View/GalleryViewController.swift 60.97% <100%> (+19.94%) ⬆️
...ctionView/UICoollectionView+CellRegistration.swift
...re/Core/Extensions/UINib/UINib+Instantiation.swift
...UIViewController/UIViewController+Storyboard.swift
...ons/UITableView/UITableView+CellRegistration.swift
...ensions/UIViewController/UIViewController+Rx.swift
...ore/Extensions/Storyboard/Storyboard+Dismiss.swift
.../Core/Extensions/UIView/UIView+Instantiation.swift

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18c0463...75a393f. Read the comment docs.

self.name = name
self.value = value
}

public static func ==(lhs: AboutInfo, rhs: AboutInfo) -> Bool {

This comment has been minimized.

@houndci-bot

houndci-bot Mar 14, 2019

Operator Function Whitespace Violation: Operators should be surrounded by a single whitespace when defining them. (operator_whitespace)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.