Add methods for creating TOTP/HOTP from raw bytes and from base32-encoded strings - #2
Merged
Merged
Conversation
messense
reviewed
Aug 8, 2019
| false | ||
| } | ||
|
|
||
| pub fn base32_secret(&self) -> String { |
Contributor
Author
There was a problem hiding this comment.
Actually this method is quite useful for users of the crate. You can create the secret using securely-generated random bytes, and then you can get the base32 secret which is the standard format (other than QR codes) for giving the secret to users.
messense
reviewed
Aug 8, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the crate only accepts secrets in the form of
Strings, which are valid UTF-8 by definition. The UTF-8 bytes of the string are then taken directly as the OTP secret. This is an unnecessary restriction on the possible secrets and significantly reduces the entropy in the resulting secret.I added new methods for creating
TOTPandHOTPfrom raw bytes and from base32-encoded strings.Given the security shortcomings of the existing approach, I would also suggest that a release including these changes deprecate or remove the current
newmethod and include a strong recommendation in the documentation/README to move to thefrom_bytes/from_base32methods.I used
Option<T>as the return type for thefrom_base32methods in order to keep these changes self-contained, but it might be worth adding an error type and usingResultinstead.