Skip to content
This repository

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Mar 13, 2012

  1. Ben Pfaff

    ofproto-dpif: Add comments for a few VLAN splinters functions.

    CC: Min Chen <ustcer.tonychan@gmail.com>
    Signed-off-by: Ben Pfaff <blp@nicira.com>
    blp authored

Mar 12, 2012

  1. Ben Pfaff

    tests: Skip "strings at least 2 characters long" test for narrow Python.

    Narrow Python can't handle Unicode characters outside the BMP, so skip the
    test.
    
    Reported-by: Michael Shigorin <mike@osdn.org.ua>
    Tested-by: Michael Shigorin <mike@osdn.org.ua>
    Signed-off-by: Ben Pfaff <blp@nicira.com>
    blp authored

Mar 08, 2012

  1. Ben Pfaff

    netdev-linux: Use "read", not "recv", for tap devices.

    "recv" only works for sockets, but tap devices aren't sockets.
    
    Makes the userspace switch work again.
    
    Reported-by: Ravi Kerur <Ravi.Kerur@telekom.com>
    Reported-by: 胡靖飞 <hujingfei914@msn.com>
    Signed-off-by: Ben Pfaff <blp@nicira.com>
    blp authored

Mar 05, 2012

  1. Ben Pfaff

    vswitchd: Document behavior of 802.1p priorities with VLAN splinters.

    Reported-by: likunyun <kunyunli@hotmail.com>
    Signed-off-by: Ben Pfaff <blp@nicira.com>
    blp authored
  2. Ben Pfaff

    bridge: Remove unwanted ports at time of ofproto creation.

    The reconfiguration code only deleted unwanted ports for bridges that had
    been created in previous (re)configurations.  In fact, we should run this
    step even for bridges that are newly added, e.g. to delete ports that
    were added by a previous run of ovs-vswitchd and deleted from the database
    between runs.
    
    Before this commit, the following left "int" in datapath br0.  After this
    commit, "int" is properly deleted:
    
    1. With ovs-vswitchd running:
          # ovs-vsctl add-br br0
          # ovs-vsctl add-port br0 int -- set interface int type=internal
    2. Kill ovs-vswitchd, then:
          # ovs-vsctl --no-wait -- del-port br0 int
    3. Restart ovs-vswitchd.
    
    Bug #9957.
    Reported-by: Hiroshi Tanaka <htanaka@nicira.com>
    Signed-off-by: Ben Pfaff <blp@nicira.com>
    blp authored

Mar 02, 2012

  1. Ben Pfaff

    connmgr: Make "enable-async-messages" work for primary controllers too.

    I only tested this feature with service controllers.
    
    Bug #9964.
    Reported-by: James Schmidt <jschmidt@nicira.com>
    Signed-off-by: Ben Pfaff <blp@nicira.com>
    blp authored
  2. Ben Pfaff

    debian: Move PKI directory to FHS-compliant location.

    The PKI directory is mutable state, so it should be in /var, not in /usr.
    This commit changes its location and, on systems upgraded from earlier
    versions, moves the existing PKI and leaves behind a symlink.
    
    CC: 661090@bugs.debian.org
    Reported-by: Andreas Beckmann <debian@abeckmann.de>
    Signed-off-by: Ben Pfaff <blp@nicira.com>
    blp authored

Feb 03, 2012

  1. Ben Pfaff

    debian: Don't install Python modules for obsolete Python versions.

    Python 2.4 is obsolete, not present in Debian squeeze or sid, so don't
    install Python modules for it.
    
    It would be better to just put the files directly into
    /usr/share/pyshared/ovs/, instead of in site-packages for some specific
    Python version, but this causes problems for builds on squeeze, as
    documented in commit bc3aa0b (debian: Make python-openvswitch packaging
    work with squeeze dh_python2.):
    
        The dh_python2 helper in Debian squeeze has a limitation that is not
        mentioned anywhere, as far as I can tell: Python files must be in
        /usr/lib/python#.#/site-packages to be installed.  The version in Debian
        wheezy does not have the same limitation.
    
        This meant that building the Debian packages on squeeze silently produced
        a broken python-openvswitch package, whereas building the same thing on
        wheezy built a working package.
    
        This fixes the problem by putting the .py files where squeeze expects them.
        It works on wheezy too.
    
    A before-and-after "debdiff" shows that the only significant effect of this
    commit is to drop python2.4 symlinks.
    
    CC: horms@debian.org
    Reported-by: Luca Falavigna <ftpmaster@debian.org>
    Signed-off-by: Ben Pfaff <blp@nicira.com>
    blp authored
  2. Ben Pfaff

    tests: Reduce risk of port collision and remove bash dependency.

    A few tests need a random TCP port on which to listen for connections.
    Until now, the tests have used the $RANDOM bash extension to do this, but
    this runs the risk of occasionally colliding with an in-use port.  This
    commit removes the bash dependency by switching to using a small Perl
    program to pick random ports and reduces the risk of collision by
    attempting to bind the port that it chooses.
    
    Reported-by: Timothy Chen <tchen@nicira.com>
    Signed-off-by: Ben Pfaff <blp@nicira.com>
    blp authored

Jan 27, 2012

  1. Ben Pfaff

    ovs-ofctl: Fix "snoop" command.

    The vconn that "snoop" opens does not process and reply to requests, so
    sending a request to set the packet-in format will hang forever, which
    means that "snoop" never actually prints any of the traffic that it
    receives.
    
    Bug #9346.
    Reported-by: Alan Shieh <ashieh@nicira.com>
    Signed-off-by: Ben Pfaff <blp@nicira.com>
    blp authored

Jan 16, 2012

  1. Ben Pfaff

    ovs-ctl: Do not load brcompat_mod if the bridge module is already loa…

    …ded.
    
    brcompat_mod and the Linux bridge module are incompatible, so it doesn't
    make sense to try to load both at the same time.  This commit prevents
    ovs-ctl from trying.
    
    Signed-off-by: Ben Pfaff <blp@nicira.com>
    Reported-by: Rogério Vinhal Nunes
    Launchpad bug #917309.
    blp authored

Jan 10, 2012

  1. Ben Pfaff

    debian: Look in /lib/modules instead of /usr/src for DKMS kernel sour…

    …ces.
    
    DKMS packages usually look in /lib/modules for kernel sources, since that
    is the "standard" location, but our packages was looking directly in
    /usr/src.  This fixes the problem.
    
    Reported-by: Alban Browaeys <prahal@yahoo.com>
    Tested-by: Alban Browaeys <prahal@yahoo.com>
    Signed-off-by: Ben Pfaff <blp@nicira.com>
    blp authored

Jan 07, 2012

  1. Ben Pfaff

    ofproto-dpif: Keep subfacets longer to avoid assert-fail in facet_acc…

    …ount().
    
    If a subfacet expired when its facet still had statistics that had not
    yet been pushed into the rule, and the facet either used the "normal"
    action or the bridge contained a bond port, then facet_account() would
    be called after the last subfacet was removed from its facet's list of
    subfacets, triggering an assertion failure in list_front().
    
    This fixes the problem by always running facet_flush_stats() (which calls
    facet_account()) before deleting the last subfacet from a facet.
    
    This problem took a while to surface because subfacets usually expire only
    long after their statistics have been pushed into the rule.
    
    Signed-off-by: Ben Pfaff <blp@nicira.com>
    Reported-by: Mike Kruze <mkruze@nicira.com>
    Bug #9074.
    blp authored

Jan 04, 2012

  1. Ben Pfaff

    ofproto: Fix detection of in-use VLANs based on the flow table.

    I swear I tested this, but the code was obviously wrong.
    
    Signed-off-by: Ben Pfaff <blp@nicira.com>
    Reported-by: Brendan Kelley <bkelley@nicira.com>
    Bug #8729.
    blp authored

Jan 03, 2012

  1. Ben Pfaff

    AUTHORS: Move Rob Hoes to list of commit contributors.

    He is the author of at least commit 3249bb9 (xenserver: Reduce number of
    xapi DB calls in plugin).
    
    Signed-off-by: Ben Pfaff <blp@nicira.com>
    blp authored
  2. Ben Pfaff

    AUTHORS: Add Dominic Curran <dominic.curran@citrix.com>.

    Signed-off-by: Ben Pfaff <blp@nicira.com>
    blp authored

Dec 12, 2011

  1. Ben Pfaff

    bridge: Enable support for access and native VLAN ports on bonds.

    Since Open vSwitch's inception we've disabled the use of bonds as access
    ports, for no particularly good reason.  This also unintentionally
    prevented bonds from being used as native VLAN ports.
    
    This commit removes the code that prevented using bonds these ways
    
    Reported-and-tested-by: "Michael A. Collins" <mike.a.collins@ark-net.org>
    Signed-off-by: Ben Pfaff <blp@nicira.com>
    blp authored

Dec 09, 2011

  1. Ben Pfaff

    ovs-ofctl: Fix misspelling in manpage.

    Reported-by: Paul Ingram <paul@nicira.com>
    blp authored
  2. Ben Pfaff

    AUTHORS: Add Chris Wright.

    blp authored

Dec 01, 2011

  1. Ben Pfaff

    INSTALL.XenServer: Update instructions.

    The instructions hadn't been properly updated to match current XenServer
    releases.
    
    Reported-by: Ramana Reddy <gtvrreddy@gmail.com>
    blp authored

Nov 10, 2011

  1. Ben Pfaff

    debian: Strip epoch from version number used in directory names.

    This doesn't fix a visible bug, since there's no epoch in the Open vSwitch
    version used in Debian, but some Nicira internal build scripts were
    inserting an epoch so it was visible in our builds.
    
    Reported-by: Edwin Chiu <echiu@nicira.com>
    blp authored

Nov 02, 2011

  1. Ben Pfaff

    stream: Fix uninitialized values in stream_init().

    stream_init() didn't initialize the remote_ip, remote_port, local_ip, or
    local_port members of the stream, so "unix" streams that don't have any of
    those would get random values instead.
    
    Reported-by: "Voravit T." <voravit@kth.se>
    Reported-by: Jari Sundell <sundell.software@gmail.com>
    blp authored

Nov 01, 2011

  1. Ben Pfaff

    AUTHORS: Add Edward Tomasz Napierała.

    blp authored

Oct 31, 2011

  1. Ben Pfaff

    netdev-vport: Again allow "tap" devices to be added to bridges.

    I did not check that tap devices otherwise work.  This at least allows
    them to be part of a bridge again.
    
    Reported-by: Janis Hamme <janis.hamme@student.kit.edu>
    blp authored

Oct 18, 2011

  1. Ben Pfaff

    ofp-util: Avoid misaligned memory access in ofputil_encode_packet_in().

    Reported-by: Murphy McCauley <murphy.mccauley@gmail.com>
    blp authored

Oct 17, 2011

  1. Ben Pfaff

    bond: Demote active-backup WARN to DBG.

    This log message comes up for packets that are flooded through the network.
    If the upstream switch doesn't realize that an active-backup bond is in
    use, and there is significant packet flooding in the network, then we will
    get a lot of these messages.
    
    (This message doesn't get logged for multicast or broadcast packets since
    they get dropped earlier in the function.)
    
    Reported-by: Eivind Bulie Haanaes
    Bug-report: http://forums.citrix.com/thread.jspa?messageID=1589125
    CC: Paul Fazzone <pfazzone@nicira.com>
    blp authored

Oct 03, 2011

  1. Ben Pfaff

    debian: Make python-openvswitch packaging work with squeeze dh_python2.

    The dh_python2 helper in Debian squeeze has a limitation that is not
    mentioned anywhere, as far as I can tell: Python files must be in
    /usr/lib/python#.#/site-packages to be installed.  The version in Debian
    wheezy does not have the same limitation.
    
    This meant that building the Debian packages on squeeze silently produced
    a broken python-openvswitch package, whereas building the same thing on
    wheezy built a working package.
    
    This fixes the problem by putting the .py files where squeeze expects them.
    It works on wheezy too.
    
    Bug #7510.
    Reported-by: Michael Hu <mhu@nicira.com>
    Tested-by: Simon Horman <horms@verge.net.au>
    blp authored

Sep 29, 2011

  1. Ben Pfaff

    bridge: Clear out all Interface fields when an interface cannot be cr…

    …eated.
    
    When an Interface record is invalid (for example, when the interface that
    it specifies does not exist and cannot be created), ovs-vswitchd would
    leave any pre-existing data in its columns, except that it would set the
    ofport column to -1 to indicate the error.  This was sometimes confusing
    because, for example, the lacp_current field could still be set to "true"
    if LACP has previously been active and up-to-date.
    
    This commit changes ovs-vswitchd to reset all such data to its default
    values when an interface is invalid.
    
    Bug #7450.
    Reported-by: Duffie Cooley <dcooley@nicira.com>
    Bug #7491.
    Reported-by: Ethan Jackson <ethan@nicira.com>
    Release Notes #7500.
    Reported-by: Keith Amidon <keith@nicira.com>
    blp authored

Sep 20, 2011

  1. Ben Pfaff

    debian: Correct path to ovs-controller in init script.

    Reported-by: George Shuklin <amarao@desunote.ru>
    Bug-report: http://bugs.debian.org/642206
    blp authored

Sep 15, 2011

  1. Ben Pfaff

    AUTHORS: Add Tyler Coumbes <coumbes@gmail.com>.

    blp authored
  2. Ben Pfaff

    ovs-vsctl: Improve usage message.

    Bug #7332.
    Reported-by: Gordon Good <ggood@nicira.com>
    blp authored

Jul 27, 2011

  1. Ben Pfaff

    ovs-ofctl: New --readd option for "replace-flows".

    This is useful for resetting flows' byte and packet counters to 0.
    
    Suggested-by: Jed Daniels <openvswitch@jeddaniels.com>
    blp authored

Jul 26, 2011

  1. Ben Pfaff

    debian: Modernize use of dh_install.

    Originally I intended this as just a cleanup, but as a side effect it also
    installs some files from the install tree in debian/tmp instead of from
    _debian.  This should avoid a reported problem in which ovs-bugtool was
    being created in the source directory instead of the build directory (I
    still don't see why this happened).
    
    Reported-by: Sébastien RICCIO <sr@swisscenter.com>
    Tested-by: Sébastien RICCIO <sr@swisscenter.com>
    Acked-by: Simon Horman <horms@verge.net.au>
    CC: Simon Horman <horms@verge.net.au>
    blp authored

Jun 15, 2011

  1. Ben Pfaff

    PORTING: Improve second diagram.

    Suggested-by: Peter Phaal <peter.phaal@inmon.com>
    blp authored

Jun 14, 2011

  1. Ben Pfaff

    AUTHORS: Add Hao Zheng <hzheng@nicira.com>.

    blp authored
Something went wrong with that request. Please try again.