Fix DSv3 model weight initialization for PP #234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xmfan
added a commit
that referenced
this pull request
Nov 5, 2025
stack-info: PR: #234, branch: xmfan/stack/15
meta-cla
bot
added
the
CLA Signed
xmfan
added a commit
that referenced
this pull request
Nov 5, 2025
stack-info: PR: #234, branch: xmfan/stack/15
sanketpurandare
approved these changes
Nov 6, 2025
Contributor
sanketpurandare
left a comment
sanketpurandare
left a comment
There was a problem hiding this comment.
Just push the linting fix and land this
xmfan
added a commit
that referenced
this pull request
Nov 6, 2025
stack-info: PR: #234, branch: xmfan/stack/15
stack-info: PR: #234, branch: xmfan/stack/15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
Fix DSv3 model weight initialization for PP
Still some NaNs on a small number of microbatch forwards
Not yet run-to-run deterministic: https://www.internalfb.com/intern/diffing/?paste_number=2025322222