Skip to content

Fix configs for 'aten' bucketing #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wconstab merged 1 commit into from
Nov 7, 2025
Merged

Fix configs for 'aten' bucketing #236

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 6 additions & 13 deletions autoparallel/auto_bucketing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,21 +119,14 @@ def aten_autobucketing_reordering_pass(
def configure_inductor_for_autobucketing(mode: str = "aten"):
# allow configuring inductor comms optimizations from torchtitan commandline
if mode == "aten":
from autoparallel.auto_bucketing import (
aten_autobucketing_config,
aten_autobucketing_reordering_pass,
)

# this is from the stacked pr in https://github.com/pytorch/pytorch/pull/163960
torch._inductor.config.reorder_for_peak_memory = False
torch._inductor.config.reorder_for_compute_comm_overlap = False
aten_autobucketing_reordering_pass = partial(
aten_autobucketing_reordering_pass,
configs=aten_autobucketing_config, # type: ignore
torch._inductor.config.aten_distributed_optimizations.enable_overlap_scheduling = (
True
)
torch._inductor.config.post_grad_custom_post_pass = (
aten_autobucketing_reordering_pass # type: ignore
torch._inductor.config.aten_distributed_optimizations.collective_bucketing = (
True
)
torch._inductor.config.aten_distributed_optimizations.insert_overlap_deps = True
torch._inductor.config.aten_distributed_optimizations.max_compute_pre_fetch = 10
elif mode == "inductor":
from autoparallel.auto_bucketing import (
simple_fsdp_autobucketing_reordering_pass,
Expand Down