Skip to content

Conversation

@saitcakmak
Copy link
Contributor

Summary:
Update the Ax-related tutorials in BoTorch to use the BOTORCH_MODULAR interface.

For starters, this updates custom BoTorch model tutorial. I will update others based on feedback on the style.

Differential Revision: D34646421

@facebook-github-bot facebook-github-bot added CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported labels Mar 4, 2022
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D34646421

@codecov
Copy link

codecov bot commented Mar 4, 2022

Codecov Report

Merging #1105 (e6d73ed) into main (30a4de8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1105   +/-   ##
=======================================
  Coverage   99.98%   99.98%           
=======================================
  Files         113      113           
  Lines        9672     9672           
=======================================
  Hits         9671     9671           
  Misses          1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30a4de8...e6d73ed. Read the comment docs.

@Balandat
Copy link
Contributor

Balandat commented Mar 5, 2022

Thanks for updating this! I wonder if instead of the Ax Developer API we should instead (or in addition) use the Service API in this tutorial? This would probably make it more concise and easier for people to follow. @lena-kashtelyan, any thoughts on this?

@meta-pytorch meta-pytorch deleted a comment from Balandat Mar 7, 2022
saitcakmak added a commit to saitcakmak/botorch that referenced this pull request Mar 8, 2022
Summary:
Pull Request resolved: meta-pytorch#1105

Update the Ax-related tutorials in BoTorch to use the BOTORCH_MODULAR interface.

For starters, this updates custom BoTorch model tutorial. I will update others based on feedback on the style.

Differential Revision: D34646421

fbshipit-source-id: 203851ce9a0ba3f802ef6cb65be45bf6d6589356
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D34646421

Summary:
Pull Request resolved: meta-pytorch#1105

Update the Ax-related tutorials in BoTorch to use the BOTORCH_MODULAR interface.

For starters, this updates custom BoTorch model tutorial. I will update others based on feedback on the style.

Differential Revision: D34646421

fbshipit-source-id: 3e8a60b311a6d7aaf7860e384b7e45d515a09beb
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D34646421

@saitcakmak saitcakmak deleted the export-D34646421 branch March 11, 2022 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants