Skip to content

Conversation

@sdaulton
Copy link
Contributor

@sdaulton sdaulton commented Jan 4, 2021

Summary: see title

Differential Revision: D25738677

@facebook-github-bot facebook-github-bot added CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported labels Jan 4, 2021
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D25738677

sdaulton added a commit to sdaulton/botorch that referenced this pull request Jan 4, 2021
Summary:
Pull Request resolved: meta-pytorch#658

see title. This also handles the edge case of zero points on the pareto frontier

Differential Revision: D25738677

fbshipit-source-id: 1664acab343de36fb3c114c623a1f3eba4be42ed
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D25738677

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D25738677

sdaulton added a commit to sdaulton/botorch that referenced this pull request Jan 4, 2021
Summary:
Pull Request resolved: meta-pytorch#658

see title. This also handles the edge case of zero points on the pareto frontier

Differential Revision: D25738677

fbshipit-source-id: d4c9285b8398ab38d89020d6f74f8fd3e997bec1
sdaulton added a commit to sdaulton/botorch that referenced this pull request Jan 4, 2021
Summary:
Pull Request resolved: meta-pytorch#658

see title. This also handles the edge case of zero points on the pareto frontier

Differential Revision: D25738677

fbshipit-source-id: 653fab86d0f2eff74a3aab0d580ca927edf72593
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D25738677

sdaulton added a commit to sdaulton/botorch that referenced this pull request Jan 4, 2021
Summary:
Pull Request resolved: meta-pytorch#658

see title. This also handles the edge case of zero points on the pareto frontier

Differential Revision: D25738677

fbshipit-source-id: 6751a63719c015be9d8eeed0aaaa6996896978b8
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D25738677

@codecov
Copy link

codecov bot commented Jan 4, 2021

Codecov Report

Merging #658 (775b86e) into master (1e3dd1e) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #658   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           93        97    +4     
  Lines         6480      6537   +57     
=========================================
+ Hits          6480      6537   +57     
Impacted Files Coverage Δ
botorch/utils/multi_objective/__init__.py 100.00% <ø> (ø)
botorch/acquisition/multi_objective/analytic.py 100.00% <100.00%> (ø)
botorch/acquisition/multi_objective/monte_carlo.py 100.00% <100.00%> (ø)
botorch/acquisition/utils.py 100.00% <100.00%> (ø)
botorch/utils/multi_objective/box_decomposition.py 100.00% <100.00%> (ø)
...ils/multi_objective/box_decompositions/__init__.py 100.00% <100.00%> (ø)
..._objective/box_decompositions/box_decomposition.py 100.00% <100.00%> (ø)
...ulti_objective/box_decompositions/non_dominated.py 100.00% <100.00%> (ø)
.../utils/multi_objective/box_decompositions/utils.py 100.00% <100.00%> (ø)
botorch/utils/multi_objective/pareto.py 100.00% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e3dd1e...775b86e. Read the comment docs.

sdaulton added a commit to sdaulton/botorch that referenced this pull request Jan 11, 2021
Summary:
Pull Request resolved: meta-pytorch#658

see title. This also handles the edge case of zero points on the pareto frontier

Reviewed By: Balandat

Differential Revision: D25738677

fbshipit-source-id: cd791b0b4ec33b7598667141995c45f085b6f4cc
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D25738677

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D25738677

sdaulton added a commit to sdaulton/botorch that referenced this pull request Jan 11, 2021
Summary:
Pull Request resolved: meta-pytorch#658

see title. This also handles the edge case of zero points on the pareto frontier

Reviewed By: Balandat

Differential Revision: D25738677

fbshipit-source-id: e8199a017a0f40fbe09d1a9985cec80df8ef22a1
sdaulton added a commit to sdaulton/botorch that referenced this pull request Jan 11, 2021
Summary:
Pull Request resolved: meta-pytorch#658

see title. This also handles the edge case of zero points on the pareto frontier

Reviewed By: Balandat

Differential Revision: D25738677

fbshipit-source-id: 5b5c879b3b49fa8464ceda135a625f5d202859da
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D25738677

sdaulton added a commit to sdaulton/botorch that referenced this pull request Jan 11, 2021
Summary:
Pull Request resolved: meta-pytorch#658

see title. This also handles the edge case of zero points on the pareto frontier

Differential Revision: D25738677

fbshipit-source-id: c036dcac60f5708e718b7e5fd0b1fe666def8499
sdaulton added a commit to sdaulton/botorch that referenced this pull request Jan 11, 2021
Summary:
Pull Request resolved: meta-pytorch#658

see title. This also handles the edge case of zero points on the pareto frontier

Reviewed By: Balandat

Differential Revision: D25738677

fbshipit-source-id: 848ddc99f069f453a587d303f667516a34c03f7c
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D25738677

sdaulton added a commit to sdaulton/botorch that referenced this pull request Jan 11, 2021
Summary:
Pull Request resolved: meta-pytorch#658

see title. This also handles the edge case of zero points on the pareto frontier

Differential Revision: D25738677

fbshipit-source-id: f54f47f1d472155e19c7f995c1a435aba10c61af
sdaulton added a commit to sdaulton/botorch that referenced this pull request Jan 11, 2021
Summary:
Pull Request resolved: meta-pytorch#658

see title. This also handles the edge case of zero points on the pareto frontier

Differential Revision: D25738677

fbshipit-source-id: 3998c2c967e35296cd09cbefe40af827c5ddff45
…ructure (meta-pytorch#656)

Summary:
Pull Request resolved: meta-pytorch#656

see title. This will tidy things up for future additions.

This also requires that a reference point is specified upon initialization.

Differential Revision: D25725167

fbshipit-source-id: 07cf6b9bd0d5df5594b04c26b4187286ca7c5803
Summary:
Pull Request resolved: meta-pytorch#657

see title. Before there could be duplicates in the pareto set.

Differential Revision: D25753915

fbshipit-source-id: cfb51e798d8fb3c9f09038c01d6c88cc717cb9f3
Summary:
Pull Request resolved: meta-pytorch#658

see title. This also handles the edge case of zero points on the pareto frontier

Reviewed By: Balandat

Differential Revision: D25738677

fbshipit-source-id: 34943259d0dda8f5040b41299437b1218ad1db48
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D25738677

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 863106f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported Merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants