Implements AppendFeatures #820
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D28981162 |
Contributor
Author
|
We need a better name for this transform. Any suggestions @RaulAstudillo06 @danielrjiang ? |
Codecov Report
@@ Coverage Diff @@
## master #820 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 107 107
Lines 7624 7638 +14
=========================================
+ Hits 7624 7638 +14
Continue to review full report at Codecov.
|
Contributor
|
In terms of alternative names for AddWTransform, I wonder if AddContextDistributionTransform Or AppendContextDistrivutionTransform or AppendContexts (adding Transform to the class name feels kind of redundant since it’s already in the transform module (cc @Balandat ). In general some more concrete examples or motivation in the doc strings and or comments could be helpful. |
Contributor
Author
Contributor
|
also cc @bletham |
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
Jun 10, 2021
Summary: Pull Request resolved: meta-pytorch#820 Renamed to: AddEnvironmentalVariables Implements AddWTransform for built-in risk measure support in BoTorch. AddWTransform: - Adds a given set of W's to the input for joint posterior evaluation. - Desperately needs a better name! RiskMeasureMCObjective: Moved to D28986749 (meta-pytorch@5ab5a56) - Takes these jointly evaluated samples and converts them into samples of the risk measure. Differential Revision: D28981162 fbshipit-source-id: 9ecc2106b86ecafb19c9a008117e554646aab225
saitcakmak
force-pushed
the
export-D28981162
branch
from
9c963f7 to
21707e3
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D28981162 |
saitcakmak
changed the title
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
Jun 15, 2021
Summary: Pull Request resolved: meta-pytorch#820 Renamed to: AppendEnvironmentalVariables Implements AddWTransform for built-in risk measure support in BoTorch. AddWTransform: - Adds a given set of W's to the input for joint posterior evaluation. - Desperately needs a better name! RiskMeasureMCObjective: Moved to D28986749 (meta-pytorch@5ab5a56) - Takes these jointly evaluated samples and converts them into samples of the risk measure. Reviewed By: sdaulton Differential Revision: D28981162 fbshipit-source-id: adb74e640f355b47d62e718c2bc0d6fc8fd5ec88
saitcakmak
force-pushed
the
export-D28981162
branch
from
21707e3 to
2a127aa
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D28981162 |
saitcakmak
changed the title
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
Jun 15, 2021
Summary: Pull Request resolved: meta-pytorch#820 Renamed to: AppendEnvironmentalVariables Implements AddWTransform for built-in risk measure support in BoTorch. AddWTransform: - Adds a given set of W's to the input for joint posterior evaluation. - Desperately needs a better name! RiskMeasureMCObjective: Moved to D28986749 (meta-pytorch@5ab5a56) - Takes these jointly evaluated samples and converts them into samples of the risk measure. Reviewed By: sdaulton Differential Revision: D28981162 fbshipit-source-id: 0f692ae0473fe58533d5e61bbaad4a9d9918ee21
saitcakmak
force-pushed
the
export-D28981162
branch
from
2a127aa to
631ee5f
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D28981162 |
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
Jun 16, 2021
Summary: Pull Request resolved: meta-pytorch#820 Renamed to: AppendEnvironmentalVariables Implements AddWTransform for built-in risk measure support in BoTorch. AddWTransform: - Adds a given set of W's to the input for joint posterior evaluation. - Desperately needs a better name! RiskMeasureMCObjective: Moved to D28986749 (meta-pytorch@5ab5a56) - Takes these jointly evaluated samples and converts them into samples of the risk measure. Reviewed By: sdaulton Differential Revision: D28981162 fbshipit-source-id: 99858403cc15ace201bfe2accd170f419af3b738
saitcakmak
force-pushed
the
export-D28981162
branch
from
631ee5f to
38adbba
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D28981162 |
saitcakmak
changed the title
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
Jun 16, 2021
Summary: Pull Request resolved: meta-pytorch#820 Implements AppendFeatures for built-in risk measure support in BoTorch. AppendFeatures: - Appends a given set of features to the input for joint posterior evaluation. - For a `batch x q x d`-dim input `X` and a `n_f x d_f`-dim `feature_set`, this results in a `batch x (q * n_f) x (d + d_f)`-dim tensor of appended inputs. Reviewed By: sdaulton Differential Revision: D28981162 fbshipit-source-id: b4903edff582a36c42134e8682e8b156c79829b3
saitcakmak
force-pushed
the
export-D28981162
branch
from
38adbba to
c8e0ad0
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D28981162 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D28981162 |
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
Jun 16, 2021
Summary: Pull Request resolved: meta-pytorch#820 Implements AppendFeatures for built-in risk measure support in BoTorch. AppendFeatures: - Appends a given set of features to the input for joint posterior evaluation. - For a `batch x q x d`-dim input `X` and a `n_f x d_f`-dim `feature_set`, this results in a `batch x (q * n_f) x (d + d_f)`-dim tensor of appended inputs. Reviewed By: sdaulton Differential Revision: D28981162 fbshipit-source-id: 78d950d1e1f73cc37a474f651309cca11d472667
saitcakmak
force-pushed
the
export-D28981162
branch
from
c8e0ad0 to
60d3736
Compare
Summary: Pull Request resolved: meta-pytorch#820 Implements AppendFeatures for built-in risk measure support in BoTorch. AppendFeatures: - Appends a given set of features to the input for joint posterior evaluation. - For a `batch x q x d`-dim input `X` and a `n_f x d_f`-dim `feature_set`, this results in a `batch x (q * n_f) x (d + d_f)`-dim tensor of appended inputs. Reviewed By: sdaulton Differential Revision: D28981162 fbshipit-source-id: f177b20e8162d7a43ae90c3206ede9215ee03dc7
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D28981162 |
saitcakmak
force-pushed
the
export-D28981162
branch
from
60d3736 to
80d68fd
Compare
Contributor
|
This pull request has been merged in afaa96c. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Implements AppendFeatures for built-in risk measure support in BoTorch.
AppendFeatures:
batch x q x d-dim inputXand an_f x d_f-dimfeature_set, this results in abatch x (q * n_f) x (d + d_f)-dim tensor of appended inputs.Differential Revision: D28981162