Make variance optional for TransformedPosterior.mean call
#855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D29506115 |
Codecov Report
@@ Coverage Diff @@
## master #855 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 108 108
Lines 8030 8034 +4
=========================================
+ Hits 8030 8034 +4
Continue to review full report at Codecov.
|
…ytorch#855) Summary: Pull Request resolved: meta-pytorch#855 Currently, `TransformedPosterior.mean` throws an error if the `_posterior` doesn't have a `variance` attribute or if the `variance` throws a `NotImplementedError`. This wraps `_posterior.variance` with a `try/except` block to support the use with posteriors that don't have a `variance`. Differential Revision: D29506115 fbshipit-source-id: 9c3188804bee7c303d870d853e95595d8784a64f
saitcakmak
force-pushed
the
export-D29506115
branch
from
f8891ef to
1bd3cc0
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D29506115 |
Contributor
|
This pull request has been merged in 2982130. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Currently,
TransformedPosterior.meanthrows an error if the_posteriordoesn't have avarianceattribute or if thevariancethrows aNotImplementedError. This wraps_posterior.variancewith atry/exceptblock to support the use with posteriors that don't have avariance.Differential Revision: D29506115