Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion botorch/posteriors/transformed.py
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,11 @@ def mean(self) -> Tensor:
r"""The mean of the posterior as a `batch_shape x n x m`-dim Tensor."""
if self._mean_transform is None:
raise NotImplementedError("No mean transform provided.")
return self._mean_transform(self._posterior.mean, self._posterior.variance)
try:
variance = self._posterior.variance
except (NotImplementedError, AttributeError):
variance = None
return self._mean_transform(self._posterior.mean, variance)

@property
def variance(self) -> Tensor:
Expand Down
19 changes: 19 additions & 0 deletions test/posteriors/test_transformed.py
Original file line number Diff line number Diff line change
Expand Up @@ -69,3 +69,22 @@ def test_transformed_posterior(self):
p_tf_2.mean
with self.assertRaises(NotImplementedError):
p_tf_2.variance

# check that `mean` works even if posterior doesn't have `variance`
for error in (AttributeError, NotImplementedError):

class DummyPosterior(object):
mean = torch.zeros(5)

@property
def variance(self):
raise error

post = DummyPosterior()
transformed_post = TransformedPosterior(
posterior=post,
sample_transform=None,
mean_transform=lambda x, _: x + 1,
)
transformed_mean = transformed_post.mean
self.assertTrue(torch.allclose(transformed_mean, torch.ones(5)))