Skip to content

Conversation

@vivekmig
Copy link
Contributor

@vivekmig vivekmig commented Mar 2, 2020

This moves algorithm descriptions from attribute method to the class in order to make API docs more intuitive.

@vivekmig vivekmig requested review from NarineK and orionr March 2, 2020 19:14
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vivekmig has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Contributor

@NarineK NarineK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@facebook-github-bot
Copy link
Contributor

@vivekmig merged this pull request in e0402b8.

NarineK pushed a commit to NarineK/captum-1 that referenced this pull request Nov 19, 2020
Summary:
This moves algorithm descriptions from attribute method to the class in order to make API docs more intuitive.
Pull Request resolved: meta-pytorch#309

Reviewed By: NarineK

Differential Revision: D20196721

Pulled By: vivekmig

fbshipit-source-id: 5edb26089327754e2eb2dc2c6278dab4758ad107
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants