Warn if AccumulateGrad stream does not match producer node stream #1680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: ghstack-source-id: 59641aa32dc6fd027abf3276017432b693aa71f8 Pull-Request-resolved: pytorch/pytorch#165065 Fixes #ISSUE_NUMBER Opening a new PR for codev cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k pragupta msaroufim dcci X-link: pytorch/pytorch#166136 Reviewed By: ngimel Differential Revision: D85360862 Pulled By: soulitzer
|
@soulitzer has exported this pull request. If you are a Meta employee, you can view the originating Diff in D85360862. |
meta-cla
bot
added
the
CLA Signed
allenwang28
added a commit
to allenwang28/monarch-1
that referenced
this pull request
Oct 28, 2025
Summary: Changes in the PyTorch C++ layer affect Monarch's tensor engine builds. Without this change, the CI builds will pick up the latest PyTorch through build-requirements.txt. This diff removes this dependency. We see this affecting meta-pytorch#1680 Differential Revision: D85670693
allenwang28
added a commit
to allenwang28/monarch-1
that referenced
this pull request
Oct 28, 2025
Summary: Changes in the PyTorch C++ layer affect Monarch's tensor engine builds. Without this change, the CI builds will pick up the latest PyTorch through build-requirements.txt. This diff removes this dependency. We see this affecting meta-pytorch#1680 Differential Revision: D85670693
allenwang28
added a commit
to allenwang28/monarch-1
that referenced
this pull request
Oct 28, 2025
Summary: Changes in the PyTorch C++ layer affect Monarch's tensor engine builds. Without this change, the CI builds will pick up the latest PyTorch through build-requirements.txt. This diff removes this dependency. We see this affecting meta-pytorch#1680 Reviewed By: amirafzali Differential Revision: D85670693
allenwang28
added a commit
to allenwang28/monarch-1
that referenced
this pull request
Oct 28, 2025
Summary: Changes in the PyTorch C++ layer affect Monarch's tensor engine builds. Without this change, the CI builds will pick up the latest PyTorch through build-requirements.txt. This diff removes this dependency. We see this affecting meta-pytorch#1680 Reviewed By: amirafzali Differential Revision: D85670693
allenwang28
added a commit
to allenwang28/monarch-1
that referenced
this pull request
Oct 29, 2025
Summary: Changes in the PyTorch C++ layer affect Monarch's tensor engine builds. Without this change, the CI builds will pick up the latest PyTorch through build-requirements.txt. This diff removes this dependency. We see this affecting meta-pytorch#1680 Reviewed By: amirafzali Differential Revision: D85670693
allenwang28
added a commit
to allenwang28/monarch-1
that referenced
this pull request
Oct 29, 2025
Summary: Changes in the PyTorch C++ layer affect Monarch's tensor engine builds. Without this change, the CI builds will pick up the latest PyTorch through build-requirements.txt. This diff removes this dependency. We see this affecting meta-pytorch#1680 Reviewed By: amirafzali Differential Revision: D85670693
allenwang28
added a commit
to allenwang28/monarch-1
that referenced
this pull request
Oct 29, 2025
Summary: Changes in the PyTorch C++ layer affect Monarch's tensor engine builds. Without this change, the CI builds will pick up the latest PyTorch through build-requirements.txt. This diff removes this dependency. We see this affecting meta-pytorch#1680 Reviewed By: amirafzali Differential Revision: D85670693
allenwang28
added a commit
to allenwang28/monarch-1
that referenced
this pull request
Oct 29, 2025
Summary: Changes in the PyTorch C++ layer affect Monarch's tensor engine builds. Without this change, the CI builds will pick up the latest PyTorch through build-requirements.txt. This diff removes this dependency. We see this affecting meta-pytorch#1680 Reviewed By: amirafzali Differential Revision: D85670693
allenwang28
added a commit
to allenwang28/monarch-1
that referenced
this pull request
Oct 29, 2025
Summary: Changes in the PyTorch C++ layer affect Monarch's tensor engine builds. Without this change, the CI builds will pick up the latest PyTorch through build-requirements.txt. This diff removes this dependency. We see this affecting meta-pytorch#1680 Reviewed By: amirafzali Differential Revision: D85670693
allenwang28
added a commit
to allenwang28/monarch-1
that referenced
this pull request
Oct 29, 2025
Summary: Changes in the PyTorch C++ layer affect Monarch's tensor engine builds. Without this change, the CI builds will pick up the latest PyTorch through build-requirements.txt. This diff removes this dependency. We see this affecting meta-pytorch#1680 Reviewed By: amirafzali Differential Revision: D85670693
allenwang28
added a commit
to allenwang28/monarch-1
that referenced
this pull request
Oct 29, 2025
Summary: Changes in the PyTorch C++ layer affect Monarch's tensor engine builds. Without this change, the CI builds will pick up the latest PyTorch through build-requirements.txt. This diff removes this dependency. We see this affecting meta-pytorch#1680 Reviewed By: amirafzali Differential Revision: D85670693
allenwang28
added a commit
to allenwang28/monarch-1
that referenced
this pull request
Oct 29, 2025
Summary: Changes in the PyTorch C++ layer affect Monarch's tensor engine builds. Without this change, the CI builds will pick up the latest PyTorch through build-requirements.txt. This diff removes this dependency. We see this affecting meta-pytorch#1680 Reviewed By: amirafzali Differential Revision: D85670693
allenwang28
added a commit
to allenwang28/monarch-1
that referenced
this pull request
Oct 29, 2025
Summary: Changes in the PyTorch C++ layer affect Monarch's tensor engine builds. Without this change, the CI builds will pick up the latest PyTorch through build-requirements.txt. This diff removes this dependency. We see this affecting meta-pytorch#1680 Reviewed By: amirafzali Differential Revision: D85670693
allenwang28
added a commit
to allenwang28/monarch-1
that referenced
this pull request
Oct 30, 2025
Summary: Changes in the PyTorch C++ layer affect Monarch's tensor engine builds. Without this change, the CI builds will pick up the latest PyTorch through build-requirements.txt. This diff removes this dependency. We see this affecting meta-pytorch#1680 Reviewed By: amirafzali Differential Revision: D85670693
allenwang28
added a commit
to allenwang28/monarch-1
that referenced
this pull request
Oct 30, 2025
Summary: Changes in the PyTorch C++ layer affect Monarch's tensor engine builds. Without this change, the CI builds will pick up the latest PyTorch through build-requirements.txt. This diff removes this dependency. We see this affecting meta-pytorch#1680 Reviewed By: amirafzali Differential Revision: D85670693
allenwang28
added a commit
to allenwang28/monarch-1
that referenced
this pull request
Oct 30, 2025
Summary: Changes in the PyTorch C++ layer affect Monarch's tensor engine builds. Without this change, the CI builds will pick up the latest PyTorch through build-requirements.txt. This diff removes this dependency. We see this affecting meta-pytorch#1680 Reviewed By: amirafzali Differential Revision: D85670693
meta-codesync bot
pushed a commit
that referenced
this pull request
Oct 30, 2025
Summary: Pull Request resolved: #1681 Changes in the PyTorch C++ layer affect Monarch's tensor engine builds. Without this change, the CI builds will pick up the latest PyTorch through build-requirements.txt. This diff removes this dependency. We see this affecting #1680 Reviewed By: amirafzali Differential Revision: D85670693 fbshipit-source-id: 1de2188ac5c84271c41bf253f9a12fd2e2cd66e6
|
@soulitzer merged this pull request in 422f466. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
ghstack-source-id: 59641aa32dc6fd027abf3276017432b693aa71f8
Pull-Request-resolved: pytorch/pytorch#165065
Fixes #ISSUE_NUMBER
Opening a new PR for codev
cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k pragupta msaroufim dcci
X-link: pytorch/pytorch#166136
Reviewed By: ngimel
Differential Revision: D85360862
Pulled By: soulitzer