: 'configure' should merge to global config not set #1913
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
@shayne-fletcher has exported this pull request. If you are a Meta employee, you can view the originating Diff in D87339094. |
shayne-fletcher
force-pushed
the
export-D87339094
branch
from
b20402a to
364408d
Compare
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Nov 18, 2025
Summary: this diff fixes incorrect overwrite semantics in the python configuration path. previously, each kwarg passed to `configure()` called `global::set(Source::Runtime, …)`, which replaces the entire `Runtime` layer. as a result, setting multiple keys in separate calls-or even within a single call-would drop previously set `Runtime` values. the fix introduces `Attrs::absorb` and `global::create_or_update`, which perform an in‑place update of an existing layer while preserving keys not mentioned in the update. the python bridge now uses `create_or_update` instead of `set`, giving `Runtime` the incremental semantics expected by the python API. a shared `make_layer` helper removes duplicated construction logic. python‑exposed config keys for log forwarding and capture are enabled, and new tests in rust and python exercise single and multi-key configuration. Reviewed By: mariusae Differential Revision: D87339094
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Nov 18, 2025
Summary: this diff fixes incorrect overwrite semantics in the python configuration path. previously, each kwarg passed to `configure()` called `global::set(Source::Runtime, …)`, which replaces the entire `Runtime` layer. as a result, setting multiple keys in separate calls-or even within a single call-would drop previously set `Runtime` values. the fix introduces `Attrs::merge` and `global::create_or_merge`, which perform an in‑place update of an existing layer while preserving keys not mentioned in the update. the python bridge now uses `create_or_merge` instead of `set`, giving `Runtime` the incremental semantics expected by the python API. a shared `make_layer` helper removes duplicated construction logic. python‑exposed config keys for log forwarding and capture are enabled, and new tests in rust and python exercise single and multi-key configuration. Reviewed By: mariusae Differential Revision: D87339094
shayne-fletcher
force-pushed
the
export-D87339094
branch
from
364408d to
b376095
Compare
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Nov 18, 2025
Summary: this diff fixes incorrect overwrite semantics in the python configuration path. previously, each kwarg passed to `configure()` called `global::set(Source::Runtime, …)`, which replaces the entire `Runtime` layer. as a result, setting multiple keys in separate calls-or even within a single call-would drop previously set `Runtime` values. the fix introduces `Attrs::merge` and `global::create_or_merge`, which perform an in‑place update of an existing layer while preserving keys not mentioned in the update. the python bridge now uses `create_or_merge` instead of `set`, giving `Runtime` the incremental semantics expected by the python API. a shared `make_layer` helper removes duplicated construction logic. python‑exposed config keys for log forwarding and capture are enabled, and new tests in rust and python exercise single and multi-key configuration. Reviewed By: mariusae Differential Revision: D87339094
shayne-fletcher
force-pushed
the
export-D87339094
branch
from
b376095 to
ec3f5c2
Compare
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Nov 18, 2025
Summary: this diff fixes incorrect overwrite semantics in the python configuration path. previously, each kwarg passed to `configure()` called `global::set(Source::Runtime, …)`, which replaces the entire `Runtime` layer. as a result, setting multiple keys in separate calls-or even within a single call-would drop previously set `Runtime` values. the fix introduces `Attrs::merge` and `global::create_or_merge`, which perform an in‑place update of an existing layer while preserving keys not mentioned in the update. the python bridge now uses `create_or_merge` instead of `set`, giving `Runtime` the incremental semantics expected by the python API. a shared `make_layer` helper removes duplicated construction logic. python‑exposed config keys for log forwarding and capture are enabled, and new tests in rust and python exercise single and multi-key configuration. Reviewed By: mariusae Differential Revision: D87339094
shayne-fletcher
force-pushed
the
export-D87339094
branch
from
ec3f5c2 to
405b89a
Compare
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Nov 19, 2025
Summary: this diff fixes incorrect overwrite semantics in the python configuration path. previously, each kwarg passed to `configure()` called `global::set(Source::Runtime, …)`, which replaces the entire `Runtime` layer. as a result, setting multiple keys in separate calls-or even within a single call-would drop previously set `Runtime` values. the fix introduces `Attrs::merge` and `global::create_or_merge`, which perform an in‑place update of an existing layer while preserving keys not mentioned in the update. the python bridge now uses `create_or_merge` instead of `set`, giving `Runtime` the incremental semantics expected by the python API. a shared `make_layer` helper removes duplicated construction logic. python‑exposed config keys for log forwarding and capture are enabled, and new tests in rust and python exercise single and multi-key configuration. Reviewed By: mariusae Differential Revision: D87339094
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Nov 19, 2025
Summary: this diff fixes incorrect overwrite semantics in the python configuration path. previously, each kwarg passed to `configure()` called `global::set(Source::Runtime, …)`, which replaces the entire `Runtime` layer. as a result, setting multiple keys in separate calls-or even within a single call-would drop previously set `Runtime` values. the fix introduces `Attrs::merge` and `global::create_or_merge`, which perform an in‑place update of an existing layer while preserving keys not mentioned in the update. the python bridge now uses `create_or_merge` instead of `set`, giving `Runtime` the incremental semantics expected by the python API. a shared `make_layer` helper removes duplicated construction logic. python‑exposed config keys for log forwarding and capture are enabled, and new tests in rust and python exercise single and multi-key configuration. Reviewed By: mariusae Differential Revision: D87339094
Summary: this diff fixes incorrect overwrite semantics in the python configuration path. previously, each kwarg passed to `configure()` called `global::set(Source::Runtime, …)`, which replaces the entire `Runtime` layer. as a result, setting multiple keys in separate calls-or even within a single call-would drop previously set `Runtime` values. the fix introduces `Attrs::merge` and `global::create_or_merge`, which perform an in‑place update of an existing layer while preserving keys not mentioned in the update. the python bridge now uses `create_or_merge` instead of `set`, giving `Runtime` the incremental semantics expected by the python API. a shared `make_layer` helper removes duplicated construction logic. python‑exposed config keys for log forwarding and capture are enabled, and new tests in rust and python exercise single and multi-key configuration. Reviewed By: mariusae Differential Revision: D87339094
shayne-fletcher
force-pushed
the
export-D87339094
branch
from
405b89a to
4ce63c0
Compare
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Nov 19, 2025
Summary: this diff fixes incorrect overwrite semantics in the python configuration path. previously, each kwarg passed to `configure()` called `global::set(Source::Runtime, …)`, which replaces the entire `Runtime` layer. as a result, setting multiple keys in separate calls-or even within a single call-would drop previously set `Runtime` values. the fix introduces `Attrs::merge` and `global::create_or_merge`, which perform an in‑place update of an existing layer while preserving keys not mentioned in the update. the python bridge now uses `create_or_merge` instead of `set`, giving `Runtime` the incremental semantics expected by the python API. a shared `make_layer` helper removes duplicated construction logic. python‑exposed config keys for log forwarding and capture are enabled, and new tests in rust and python exercise single and multi-key configuration. Reviewed By: mariusae Differential Revision: D87339094
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Nov 19, 2025
Summary: this diff fixes incorrect overwrite semantics in the python configuration path. previously, each kwarg passed to `configure()` called `global::set(Source::Runtime, …)`, which replaces the entire `Runtime` layer. as a result, setting multiple keys in separate calls-or even within a single call-would drop previously set `Runtime` values. the fix introduces `Attrs::merge` and `global::create_or_merge`, which perform an in‑place update of an existing layer while preserving keys not mentioned in the update. the python bridge now uses `create_or_merge` instead of `set`, giving `Runtime` the incremental semantics expected by the python API. a shared `make_layer` helper removes duplicated construction logic. python‑exposed config keys for log forwarding and capture are enabled, and new tests in rust and python exercise single and multi-key configuration. Reviewed By: mariusae Differential Revision: D87339094
|
This pull request has been merged in 8efdd64. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
this diff fixes incorrect overwrite semantics in the python configuration path. previously, each kwarg passed to
configure()calledglobal::set(Source::Runtime, …), which replaces the entireRuntimelayer. as a result, setting multiple keys in separate calls-or even within a single call-would drop previously setRuntimevalues.the fix introduces
Attrs::absorbandglobal::create_or_update, which perform an in‑place update of an existing layer while preserving keys not mentioned in the update. the python bridge now usescreate_or_updateinstead ofset, givingRuntimethe incremental semantics expected by the python API. a sharedmake_layerhelper removes duplicated construction logic.python‑exposed config keys for log forwarding and capture are enabled, and new tests in the python layer exercise both single and multi-key configuration.
Differential Revision: D87339094