Skip to content

Make logs from spawn_exit_monitor part of ProcStatus #1935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Make logs from spawn_exit_monitor part of ProcStatus #1935

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 21 additions & 9 deletions hyperactor_mesh/src/bootstrap.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1741,35 +1741,47 @@ impl BootstrapProcManager {
if let Some(sig) = status.signal() {
let _ = handle.mark_killed(sig, status.core_dumped());
let pid_str = remove_from_pid_table();
tracing::debug!(
tracing::info!(
name = "ProcStatus",
status = "Exited::KilledBySignal",
%proc_id,
tail = tail_str,
"proc {proc_id} killed by signal {sig}; proc's pid: {pid_str}"
"killed by signal {sig}; proc's pid: {pid_str}"
);
} else if let Some(code) = status.code() {
let _ = handle.mark_stopped(code, stderr_tail);
let pid_str = remove_from_pid_table();
if code == 0 {
tracing::debug!(%proc_id, exit_code = code, tail = tail_str.as_deref(), "proc exited; proc's pid: {pid_str}");
} else {
tracing::info!(%proc_id, exit_code = code, tail = tail_str.as_deref(), "proc exited; proc's pid: {pid_str}");
}
tracing::info!(
name = "ProcStatus",
status = "Exited::ExitWithCode",
%proc_id,
exit_code = code,
tail = tail_str,
"proc exited; proc's pid: {pid_str}"
);
} else {
debug_assert!(
false,
"unreachable: process terminated with neither signal nor exit code"
);
let _ = handle.mark_failed("process exited with unknown status");
let pid_str = remove_from_pid_table();
tracing::error!(
tracing::info!(
name = "ProcStatus",
status = "Exited::Unknown",
%proc_id,
tail = tail_str,
"proc {proc_id} unknown exit: unreachable exit status (no code, no signal); proc's pid: {pid_str}"
"unknown exit: unreachable exit status (no code, no signal); proc's pid: {pid_str}"
);
}
}
Err(e) => {
let _ = handle.mark_failed(format!("wait_inner() failed: {e}"));
let pid_str = remove_from_pid_table();
tracing::info!(
name = "ProcStatus",
status = "Exited::WaitFailed",
%proc_id,
tail = tail_str,
"proc {proc_id} wait failed; proc's pid: {pid_str}"
);
Expand Down