Stop the proc mesh from the alloc in HostMesh::shutdown #1963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
@dulinriley has exported this pull request. If you are a Meta employee, you can view the originating Diff in D87264086. |
Summary: In order to stop the remote process allocation, we need to call `Alloc::stop`, which is done when the ProcMesh created from the allocation is itself stopped. This should ensure jobs finish entirely. Note that the Drop for ProcMesh and Drop for RemoteProcessAlloc both do not try to stop the underlying allocation, which is why this is necessary. Reviewed By: pzhan9 Differential Revision: D87264086
dulinriley
force-pushed
the
export-D87264086
branch
from
e048a1b to
54b1820
Compare
|
This pull request has been merged in b1aeca9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In order to stop the remote process allocation, we need to call
Alloc::stop, which isdone when the ProcMesh created from the allocation is itself stopped.
This should ensure jobs finish entirely.
Note that the Drop for ProcMesh and Drop for RemoteProcessAlloc both do not try to stop
the underlying allocation, which is why this is necessary.
Differential Revision: D87264086