Rename getKeyFrameIndexForPts into getKeyFrameIdentifier
#1076
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
NicolasHug
commented
Nov 28, 2025
| // TODO we should understand why (is it because it reads the file?) and | ||
| // potentially optimize it. E.g. we may not want to ever seek, or even *check* | ||
| // if we need to seek in some cases, like if we're going to decode 80% of the | ||
| // frames anyway. |
Contributor
Author
There was a problem hiding this comment.
Drive-by, my previous comment above is incorrect: getKeyFrameIndexForPts() in approximate mode is not slow. But it's not accurate (it doesn't return what we want it to return), so it's still the cause for the slowness. See #1077 for more details.
NicolasHug
commented
Nov 28, 2025
| // in [0, num_frames) like for mp4. It really depends on the container. | ||
| // | ||
| // The range of the "identifier" doesn't matter that much, for now we only | ||
| // use it to uniquely identify a key frame in canWeAvoidSeeking(). |
Contributor
Author
There was a problem hiding this comment.
I can confirm the above on some test videos with 2 key frames. mkv would return 0 and 1 like in exact mode, while mp4 returned 0 and 250!
scotts
approved these changes
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See comment for an explanation why