Expose new get_frames_at and get_frames_displayed_at methods
#303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
scotts
reviewed
Oct 28, 2024
scotts
reviewed
Oct 28, 2024
NicolasHug
commented
Oct 28, 2024
Comment on lines
+305
to
+310
| expected_frame_info = NASA_VIDEO.get_frame_info(9) | ||
| assert frame9.pts_seconds == pytest.approx(expected_frame_info.pts_seconds) | ||
| assert isinstance(frame9.duration_seconds, float) | ||
| assert frame9.duration_seconds == pytest.approx(0.03337, rel=1e-3) | ||
| assert frame9.duration_seconds == pytest.approx( | ||
| expected_frame_info.duration_seconds, rel=1e-3 | ||
| ) |
Contributor
Author
There was a problem hiding this comment.
This is just a drive-by clean-up to remove hard-coded values.
scotts
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added tests, and use these new methods in the samplers.