Skip to content

Relax test constraint for ffmpeg versions as they can be arbitrary #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ahmadsharif1 merged 2 commits into from
Oct 28, 2024
Merged

Relax test constraint for ffmpeg versions as they can be arbitrary #308

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
009c85b
Relax test constraint for ffmpeg versions as they can be arbitrary
ahmadsharif1 Oct 28, 2024
7209854
.
ahmadsharif1 Oct 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/linux_cuda_wheel.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,8 +135,7 @@ jobs:
${CONDA_RUN} python test/decoders/manual_smoke_test.py
- name: Run Python tests
run: |
# We skip test_get_ffmpeg_version because it may not have a micro version.
${CONDA_RUN} FAIL_WITHOUT_CUDA=1 pytest test -k "not test_get_ffmpeg_version" -vvv
${CONDA_RUN} FAIL_WITHOUT_CUDA=1 pytest test -vvv
- name: Run Python benchmark
run: |
${CONDA_RUN} time python benchmarks/decoders/gpu_benchmark.py --devices=cuda:0,cpu --resize_devices=none
4 changes: 1 addition & 3 deletions test/decoders/test_video_decoder_ops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,9 +423,7 @@ def test_get_ffmpeg_version(self):
# The earliest libavutil version is 50 as per:
# https://www.ffmpeg.org/olddownload.html
assert ffmpeg_dict["libavutil"][0] > 50
ffmpeg_version = ffmpeg_dict["ffmpeg_version"]
split_ffmpeg_version = [int(num) for num in ffmpeg_version.split(".")]
assert len(split_ffmpeg_version) == 3
assert "ffmpeg_version" in ffmpeg_dict

def test_frame_pts_equality(self):
decoder = create_from_file(str(NASA_VIDEO.path))
Expand Down
Loading