Skip to content

Conversation

@joshuadeng
Copy link
Contributor

Summary: tsia

Differential Revision: D31995123

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported labels Oct 28, 2021
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D31995123

4 similar comments
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D31995123

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D31995123

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D31995123

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D31995123

@facebook-github-bot
Copy link
Contributor

@joshuadeng has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D31995123

2 similar comments
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D31995123

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D31995123

@joshuadeng
Copy link
Contributor Author

pre-commit.ci run

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D31995123

2 similar comments
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D31995123

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D31995123

Summary:
tsia

Pull Request resolved: #12

Differential Revision: D31995123

Pulled By: joshuadeng

fbshipit-source-id: 5969d6f5e3bd3e1a4304626f9beb6cf568bab5ba
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D31995123

Copy link
Contributor

@colin2328 colin2328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joshuadeng -> for torchrec github, we use the facebook github bot to sync changes from fbcode (source of truth) to github. Is there a reason that we need to put this pR out manually?

facebook-github-bot pushed a commit that referenced this pull request Feb 9, 2022
…ng [1/n] (#12)

Summary:
Pull Request resolved: #12

**Preproc for dlrm inspired by NVIDIA DLRM Preproc: ** https://catalog.ngc.nvidia.com/orgs/nvidia/resources/dlrm_for_pytorch/advanced (under dataset guidelines)

- Re-map sparse ids to contiguous integers (`with this you can have an embedding table of size num_categories x emb_dim`)
- Frequency thresholding; if an id shows up less than T times, remap it to a value of 1 (`Fit model on particular GPU`, `Capture all rarely occurring categories into one because otherwise for these categories you would overfit`)

full details of benefits of this preprocessing:
- NVIDIA/DeepLearningExamples#1062 (comment)

Reviewed By: colin2328

Differential Revision: D33998505

fbshipit-source-id: 93a2fa160bcd679b9b00d970ea2288fbde0ca6f9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants