-
Notifications
You must be signed in to change notification settings - Fork 580
Set up ufmt (usort + black) as code formatter #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This pull request was exported from Phabricator. Differential Revision: D31995123 |
4 similar comments
|
This pull request was exported from Phabricator. Differential Revision: D31995123 |
|
This pull request was exported from Phabricator. Differential Revision: D31995123 |
|
This pull request was exported from Phabricator. Differential Revision: D31995123 |
|
This pull request was exported from Phabricator. Differential Revision: D31995123 |
|
@joshuadeng has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
This pull request was exported from Phabricator. Differential Revision: D31995123 |
2 similar comments
|
This pull request was exported from Phabricator. Differential Revision: D31995123 |
|
This pull request was exported from Phabricator. Differential Revision: D31995123 |
|
pre-commit.ci run |
|
This pull request was exported from Phabricator. Differential Revision: D31995123 |
2 similar comments
|
This pull request was exported from Phabricator. Differential Revision: D31995123 |
|
This pull request was exported from Phabricator. Differential Revision: D31995123 |
Summary: tsia Pull Request resolved: #12 Differential Revision: D31995123 Pulled By: joshuadeng fbshipit-source-id: 5969d6f5e3bd3e1a4304626f9beb6cf568bab5ba
|
This pull request was exported from Phabricator. Differential Revision: D31995123 |
colin2328
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joshuadeng -> for torchrec github, we use the facebook github bot to sync changes from fbcode (source of truth) to github. Is there a reason that we need to put this pR out manually?
…ng [1/n] (#12) Summary: Pull Request resolved: #12 **Preproc for dlrm inspired by NVIDIA DLRM Preproc: ** https://catalog.ngc.nvidia.com/orgs/nvidia/resources/dlrm_for_pytorch/advanced (under dataset guidelines) - Re-map sparse ids to contiguous integers (`with this you can have an embedding table of size num_categories x emb_dim`) - Frequency thresholding; if an id shows up less than T times, remap it to a value of 1 (`Fit model on particular GPU`, `Capture all rarely occurring categories into one because otherwise for these categories you would overfit`) full details of benefits of this preprocessing: - NVIDIA/DeepLearningExamples#1062 (comment) Reviewed By: colin2328 Differential Revision: D33998505 fbshipit-source-id: 93a2fa160bcd679b9b00d970ea2288fbde0ca6f9
Summary: tsia
Differential Revision: D31995123