Re-sync with internal repository #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
842974287
added a commit
to 842974287/torchrec-1
that referenced
this pull request
Feb 26, 2022
Summary: X-link: pytorch/pytorch#72839 X-link: meta-pytorch#16 `__getstate__` functions are used by pickle and the base class (PyTorch optimizer) overrides this function https://github.com/pytorch/pytorch/blob/6f29313e38881edeb8e877ed40626f56cb00c34a/torch/optim/optimizer.py#L56. Torchrec optimizer classes has different attributes from the base class which is causing AttributeNotFound error during pickling. Reviewed By: YazhiGao Differential Revision: D34147809 fbshipit-source-id: c16efa8a677fb946dc1fd308e92638068ad291e5
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 28, 2022
Summary: Pull Request resolved: #113 X-link: pytorch/pytorch#72839 X-link: #16 `__getstate__` functions are used by pickle and the base class (PyTorch optimizer) overrides this function https://github.com/pytorch/pytorch/blob/6f29313e38881edeb8e877ed40626f56cb00c34a/torch/optim/optimizer.py#L56. Torchrec optimizer classes has different attributes from the base class which is causing AttributeNotFound error during pickling. Reviewed By: houseroad, YazhiGao Differential Revision: D34147809 fbshipit-source-id: 4b261a9a2329c41bfc9712e7a4418debf73a2657
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The internal and external repositories are out of sync. This attempts to brings them back in sync by patching the GitHub repository. Please carefully review this patch. You must disable ShipIt for your project in order to merge this pull request. DO NOT IMPORT this pull request. Instead, merge it directly on GitHub using the MERGE BUTTON. Re-enable ShipIt after merging.