Remove Python type annotation hint ambiguity from the test case of KeyedOptimizer #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…yedOptimizer Summary: Following suggestions from colin2328, wanchaol and divchenko, I am decoupling the change to TorchRec out from D32502393 into this diff. Differential Revision: D32550352 fbshipit-source-id: c32eb7b542a79743a3b69a367ea39c09b474b277
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D32550352 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 19, 2022
Summary: Pull Request resolved: #20 Reviewed By: xing-liu Differential Revision: D34334374 fbshipit-source-id: c4b86fdd10ee1a175ce0e7c458706bd40cdec025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Following suggestions from colin2328, wanchaol and divchenko, I am decoupling the change to TorchRec out from D32502393 into this diff.
Differential Revision: D32550352